From: Oliver Kiddle <okiddle@yahoo.co.uk>
To: Daniel Hahler <genml+zsh-workers@thequod.de>
Cc: Zsh workers <zsh-workers@zsh.org>
Subject: Re: PATCH: completion match ordering
Date: Fri, 23 Aug 2019 21:05:52 +0200 [thread overview]
Message-ID: <21119-1566587152.200664@M-4Y.2AQ9.H2IH> (raw)
In-Reply-To: <ba7f9b90-9f9a-873d-f6a1-02b283d99191@gmail.com>
Daniel Hahler wrote:
> unfortunately this patch (Git commit cd6fd2b0a) breaks completion for
> "git commit --fixup" for me, which then looks like this:
> ..
> I hope you can reproduce this, otherwise I'd have to investigate.
I'm afraid I can't reproduce it.
Output from _complete_debug might help. Do other uses of _describe or,
more expecially _describe -V have problems? Are you certain you're using
functions matching the code and not, e.g using a new _git with an older
zsh. Perhaps try tweaking __git_recent_commits: remove the _wanted
calls, remove the -V, dump the descr array somewhere with typeset -p.
And then try completing the same array from a minimal function.
Oliver
next prev parent reply other threads:[~2019-08-23 19:06 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-04 0:13 [PATCH] Completion: Sort lz4 compression levels properly (+ a question) dana
2018-11-07 10:35 ` Oliver Kiddle
2018-11-07 17:52 ` dana
2018-11-26 1:25 ` completion match ordering Oliver Kiddle
2018-11-26 3:09 ` Daniel Shahaf
2018-11-26 5:18 ` dana
2018-11-26 9:37 ` Peter Stephenson
2018-11-26 23:07 ` dana
2019-05-06 21:16 ` PATCH: " Oliver Kiddle
2019-05-07 0:10 ` dana
2019-05-07 12:39 ` Oliver Kiddle
2019-08-22 8:39 ` Daniel Hahler
2019-08-23 19:05 ` Oliver Kiddle [this message]
2019-08-25 14:25 ` Daniel Hahler
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=21119-1566587152.200664@M-4Y.2AQ9.H2IH \
--to=okiddle@yahoo.co.uk \
--cc=genml+zsh-workers@thequod.de \
--cc=zsh-workers@zsh.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.vuxu.org/mirror/zsh/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).