zsh-workers
 help / color / mirror / code / Atom feed
From: dana <dana@dana.is>
To: Peter Stephenson <p.stephenson@samsung.com>
Cc: Zsh hackers list <zsh-workers@zsh.org>
Subject: Re: [PATCH] Silence compilation warnings about setuid, setgid
Date: Wed, 13 Jun 2018 13:41:25 -0500	[thread overview]
Message-ID: <25A87D83-CBB6-446E-9008-DA413639AC7D@dana.is> (raw)
In-Reply-To: <20180613171924eucas1p1ffdbcc9252255b19e36788fd06a7f582~3x_Aqkahf0839108391eucas1p1U@eucas1p1.samsung.com>

On 13 Jun 2018, at 12:19, Peter Stephenson <p.stephenson@samsung.com> wrote:
>+	(void)setgid(getgid());

Casting to void doesn't actually silence this warning with (at least some
versions of) GCC/glibc. If the function has the warn_unused_result attribute,
you have to (a) disable the warning entirely, (b) actually use the result
somehow, or (c) use some hack like this:
http://git.savannah.gnu.org/cgit/gnulib.git/tree/lib/ignore-value.h

dana


  reply	other threads:[~2018-06-13 18:41 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-05-07 11:18 Sebastian Gniazdowski
2018-06-13 11:49 ` Eitan Adler
2018-06-13 13:10   ` Peter Stephenson
2018-06-13 15:08     ` Bart Schaefer
2018-06-13 15:16       ` Peter Stephenson
2018-06-13 17:13       ` Eitan Adler
2018-06-13 17:19         ` Peter Stephenson
2018-06-13 18:41           ` dana [this message]
2018-06-14  8:41             ` Peter Stephenson
2018-06-14 10:31               ` dana
2018-06-14 10:40                 ` Peter Stephenson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=25A87D83-CBB6-446E-9008-DA413639AC7D@dana.is \
    --to=dana@dana.is \
    --cc=p.stephenson@samsung.com \
    --cc=zsh-workers@zsh.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this public inbox

	https://git.vuxu.org/mirror/zsh/

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).