From: Eitan Adler <lists@eitanadler.com>
To: Bart Schaefer <schaefer@brasslantern.com>
Cc: Peter Stephenson <p.stephenson@samsung.com>,
Zsh hackers list <zsh-workers@zsh.org>
Subject: Re: [PATCH] Silence compilation warnings about setuid, setgid
Date: Wed, 13 Jun 2018 10:13:53 -0700 [thread overview]
Message-ID: <CAF6rxg=Y1BSfoQLMgyLj4ahJcRp36AN8n2=hwFgxqQ4h0VkAYw@mail.gmail.com> (raw)
In-Reply-To: <CAH+w=7Z5hNeLpoUkGDMnuk3PRF3BX7+z=EdHQHTVtj1pgasrAA@mail.gmail.com>
On 13 June 2018 at 08:08, Bart Schaefer <schaefer@brasslantern.com> wrote:
> This may have been isolated to a 1990s-era OS that is no longer at
> issue. Either way there's no particular reason to save and report
> errno from the first call.
See https://wiki.sei.cmu.edu/confluence/display/c/POS37-C.+Ensure+that+privilege+relinquishment+is+successful
I'm not sure what current systems have these issues, but explicitly
checking the results of getuid after priv-drop is still considered a
"good idea"
--
Eitan Adler
next prev parent reply other threads:[~2018-06-13 17:14 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-05-07 11:18 Sebastian Gniazdowski
2018-06-13 11:49 ` Eitan Adler
2018-06-13 13:10 ` Peter Stephenson
2018-06-13 15:08 ` Bart Schaefer
2018-06-13 15:16 ` Peter Stephenson
2018-06-13 17:13 ` Eitan Adler [this message]
2018-06-13 17:19 ` Peter Stephenson
2018-06-13 18:41 ` dana
2018-06-14 8:41 ` Peter Stephenson
2018-06-14 10:31 ` dana
2018-06-14 10:40 ` Peter Stephenson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAF6rxg=Y1BSfoQLMgyLj4ahJcRp36AN8n2=hwFgxqQ4h0VkAYw@mail.gmail.com' \
--to=lists@eitanadler.com \
--cc=p.stephenson@samsung.com \
--cc=schaefer@brasslantern.com \
--cc=zsh-workers@zsh.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.vuxu.org/mirror/zsh/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).