zsh-workers
 help / color / mirror / code / Atom feed
From: Peter Stephenson <p.stephenson@samsung.com>
To: Zsh hackers list <zsh-workers@zsh.org>
Subject: Re: [PATCH] Silence compilation warnings about setuid, setgid
Date: Wed, 13 Jun 2018 16:16:00 +0100	[thread overview]
Message-ID: <20180613151604eucas1p2359cab40768707b24d71579fe0853996~3wSVPJg051449714497eucas1p2r@eucas1p2.samsung.com> (raw)
In-Reply-To: <CAH+w=7Z5hNeLpoUkGDMnuk3PRF3BX7+z=EdHQHTVtj1pgasrAA@mail.gmail.com>

On Wed, 13 Jun 2018 08:08:27 -0700
Bart Schaefer <schaefer@brasslantern.com> wrote:
> IIRC there are some cases in which setgid/setuid fail silently, i.e.,
> without changing anything but without setting errno.  The second calls
> are to double-check that the first one was not rogue in that way.
> 
> This may have been isolated to a 1990s-era OS that is no longer at
> issue.  Either way there's no particular reason to save and report
> errno from the first call.

Thanks, I'll change to a cast to void.

pws


  reply	other threads:[~2018-06-13 15:16 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-05-07 11:18 Sebastian Gniazdowski
2018-06-13 11:49 ` Eitan Adler
2018-06-13 13:10   ` Peter Stephenson
2018-06-13 15:08     ` Bart Schaefer
2018-06-13 15:16       ` Peter Stephenson [this message]
2018-06-13 17:13       ` Eitan Adler
2018-06-13 17:19         ` Peter Stephenson
2018-06-13 18:41           ` dana
2018-06-14  8:41             ` Peter Stephenson
2018-06-14 10:31               ` dana
2018-06-14 10:40                 ` Peter Stephenson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='20180613151604eucas1p2359cab40768707b24d71579fe0853996~3wSVPJg051449714497eucas1p2r@eucas1p2.samsung.com' \
    --to=p.stephenson@samsung.com \
    --cc=zsh-workers@zsh.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this public inbox

	https://git.vuxu.org/mirror/zsh/

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).