Minimal patch to _pdf

Minimal patch to _pdf

[Richard Hartmann]

[-- Attachment #1: Type: text/plain, Size: 13 bytes --]

See attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: _pdf.patch --]
[-- Type: text/x-diff; name=_pdf.patch, Size: 576 bytes --]

--- /usr/share/zsh/functions/Completion/Unix/_pdf	2008-08-09 00:51:01.000000000 +0200
+++ killme/_pdf	2008-12-02 02:20:58.928949050 +0100
@@ -1,4 +1,4 @@
-#compdef pdf2dsc pdf2ps pdfimages pdfinfo pdftopbm pdftops pdftotext pdfopt pdffonts kpdf
+#compdef pdf2dsc pdf2ps pdfimages pdfinfo pdftopbm pdftops pdftotext pdfopt pdffonts kpdf okular
 
 local expl ext=''
 
@@ -6,6 +6,10 @@
 #  pdf2dsc pdf2ps pdfopt
 # xpdf:
 #  pdfimages pdfinfo pdftopbm pdftops pdftotext xpdf pdffonts
+# KDE 3:
+#  kpdf
+# KDE 4:
+#  okular
 
 if [[ "$1" == '-z' ]]; then
   ext='(|.gz|.bz2|.Z)'

Re: Minimal patch to _pdf

[Allan Caffee]

On Mon, Dec 1, 2008 at 8:26 PM, Richard Hartmann
<richih.mailinglist@gmail.com> wrote:
> See attached
>

I noticed that your patch modifies _pdf to complete for Okular.  I
don't think you want to do that.  Okular is used for viewing documents
for many different formats like PostScript and DVI files.  By setting
its completion function to _pdf you are preventing it from completing
any of the other formats.  It would be better to create a new function
which uses _pdf and the other relevant completion functions.

Re: Minimal patch to _pdf

[Richard Hartmann]

On Tue, Dec 2, 2008 at 03:21, Allan Caffee


> Okular is used for viewing documents
> for many different formats like PostScript and DVI files.

I was not aware of that. Please scratch this patch and expect a
new one around the weekend, this time for _okular.


Richard