[PATCH] completion libvirt: edit action is always allowed

[PATCH] completion libvirt: edit action is always allowed

[sergio]

libvirt allows to edit virtrual host in any state

-- 
sergio.


diff --git a/Completion/Unix/Command/_libvirt 
b/Completion/Unix/Command/_libvirt
index a3ab5a68a..8bd3e1e6b 100644
--- a/Completion/Unix/Command/_libvirt
+++ b/Completion/Unix/Command/_libvirt
@@ -20,7 +20,7 @@ typeset -A dom_opts
  dom_opts=(
    console " "
    destroy " "
-  edit " "
+  edit --all
    managedsave " "
    reboot " "
    reset " "

Re: [PATCH] completion libvirt: edit action is always allowed

[sergio]

Why this still has not been merged?


On 09/06/2023 11:59, sergio wrote:
> libvirt allows to edit virtrual host in any state
> 

-- 
sergio.

Re: [PATCH] completion libvirt: edit action is always allowed

[Jun T]

> 2023/08/21 19:13, sergio <sergio@outerface.net> wrote:
> 
> Why this still has not been merged?

Sorry, I guess everyone here has thought that someone else
would take care of it.

> 2023/06/09 17:5, sergio <sergio@outerface.net> wrote:
> 
> libvirt allows to edit virtrual host in any state

> -  edit " "
> +  edit --all

I'm not familiar with virsh, but if --all is the correct option
to use then we can just remove dom_opts[edit] since the array
is used as ${dom_opts[$cmd]:-"--all"}.


diff --git a/Completion/Unix/Command/_libvirt b/Completion/Unix/Command/_libvirt
index a3ab5a68a..bd605b9c9 100644
--- a/Completion/Unix/Command/_libvirt
+++ b/Completion/Unix/Command/_libvirt
@@ -20,7 +20,6 @@ typeset -A dom_opts
 dom_opts=(
   console " "
   destroy " "
-  edit " "
   managedsave " "
   reboot " "
   reset " "

Re: [PATCH] completion libvirt: edit action is always allowed

[sergio]

On 22/08/2023 09:54, Jun T wrote:

> I'm not familiar with virsh, but if --all is the correct option
> to use then we can just remove dom_opts[edit] since the array
> is used as ${dom_opts[$cmd]:-"--all"}.

No, no. When I do `virsh shutdown` or `virsh console` I would like to 
only active guests (that are shown with `virsh list`). `--all` shows 
all, including powered off.

-- 
sergio.

Re: [PATCH] completion libvirt: edit action is always allowed

[Jun. T]

> 2023/08/24 6:01、sergio <sergio@outerface.net>のメール:
> 
> On 22/08/2023 09:54, Jun T wrote:
> 
>> I'm not familiar with virsh, but if --all is the correct option
>> to use then we can just remove dom_opts[edit] since the array
>> is used as ${dom_opts[$cmd]:-"--all"}.
> 
> No, no. When I do `virsh shutdown` or `virsh console` I would like to only active guests (that are shown with `virsh list`). `--all` shows all, including powered off.

dom_opts has entries for shutdown and cosole subcommands:
dom_opt[shutdown]='--state-running'
dom_opt[console]=' '

--all is used if dom_opt[subcmd] does not exists.
If you want to use -all for the subcommand 'edit', then
you can just remove dom_opt[edit].

Could you please confirm that your patch and mine give the
same list of domains for edit subcommand?

Re: [PATCH] completion libvirt: edit action is always allowed

[sergio]

> Could you please confirm that your patch and mine give the
> same list of domains for edit subcommand?

Oh, sorry, I was wrong. Yes, I tested and confirm our patches does the 
same! Yours probably better, as more clean.

-- 
sergio.