zsh-workers
 help / color / mirror / code / Atom feed
* Completion and command versions
@ 2003-03-14  0:14 Doug Kearns
  2003-03-14 10:30 ` Peter Stephenson
  0 siblings, 1 reply; 4+ messages in thread
From: Doug Kearns @ 2003-03-14  0:14 UTC (permalink / raw)
  To: zsh-workers

Is there a policy regarding the command version that completion
functions should support? What about commands where there are
significant changes between versions?

Any thoughts?

Thanks,
Doug


^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: Completion and command versions
  2003-03-14  0:14 Completion and command versions Doug Kearns
@ 2003-03-14 10:30 ` Peter Stephenson
  2003-03-14 11:58   ` Oliver Kiddle
  2003-03-19 13:45   ` Oliver Kiddle
  0 siblings, 2 replies; 4+ messages in thread
From: Peter Stephenson @ 2003-03-14 10:30 UTC (permalink / raw)
  To: zsh-workers

Doug Kearns wrote:
> Is there a policy regarding the command version that completion
> functions should support? What about commands where there are
> significant changes between versions?

The standard way is using the _pick_variant function.

If it's too dangerous to run the command to find out what it does, you
probably need a style.  `variant' is already use by _pick_variant,
unfortunately --- it's not a very good name, since it doesn't give the
variant, it gives the programme to run to pick the variant.  Of course
it could be set to a function that simply returns the type, but that
method doesn't have a sensible default.

-- 
Peter Stephenson <pws@csr.com>                  Software Engineer
CSR Ltd., Science Park, Milton Road,
Cambridge, CB4 0WH, UK                          Tel: +44 (0)1223 692070


**********************************************************************
The information transmitted is intended only for the person or
entity to which it is addressed and may contain confidential 
and/or privileged material. 
Any review, retransmission, dissemination or other use of, or
taking of any action in reliance upon, this information by 
persons or entities other than the intended recipient is 
prohibited.  
If you received this in error, please contact the sender and 
delete the material from any computer.
**********************************************************************


^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: Completion and command versions
  2003-03-14 10:30 ` Peter Stephenson
@ 2003-03-14 11:58   ` Oliver Kiddle
  2003-03-19 13:45   ` Oliver Kiddle
  1 sibling, 0 replies; 4+ messages in thread
From: Oliver Kiddle @ 2003-03-14 11:58 UTC (permalink / raw)
  To: zsh-workers

Peter wrote:
> Doug Kearns wrote:
> > Is there a policy regarding the command version that completion
> > functions should support? What about commands where there are
> > significant changes between versions?

I don't think we have any official policy. For most commands, where the
differences are little more than a few added options I just update it
to the latest version.

If an option that takes an argument is removed you could precede the
_arguments spec with \! so that it is recognised but not completed.

Where a command changes significantly, and in particular where an old
version continues to be in wide use, it can then be worth the trouble
of handling the old version.

> The standard way is using the _pick_variant function.
> 
> If it's too dangerous to run the command to find out what it does, you
> probably need a style.  `variant' is already use by _pick_variant,
> unfortunately --- it's not a very good name, since it doesn't give the
> variant, it gives the programme to run to pick the variant.  Of course

_pick_variant is not in 4.0 so it isn't too late to change this. It
perhaps should stick with the command style but set the tag to `variant'
when looking it up.

Another issue we perhaps ought to think about is how we keep track
of what version of a command the functions have been updated to. I
notice some people have put a version number in a comment at the top
of functions which is one way. What we could do is setup a separate cvs
repository containing the output of the commands' --help (or equivalent)
outputs. I've found that diffing these is a good way of finding any
new options - assuming I still have the old program around to get it's
--help output.

Oliver


^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: Completion and command versions
  2003-03-14 10:30 ` Peter Stephenson
  2003-03-14 11:58   ` Oliver Kiddle
@ 2003-03-19 13:45   ` Oliver Kiddle
  1 sibling, 0 replies; 4+ messages in thread
From: Oliver Kiddle @ 2003-03-19 13:45 UTC (permalink / raw)
  To: zsh-workers

On 14 Mar, Peter wrote:
> 
> The standard way is using the _pick_variant function.
> 
> If it's too dangerous to run the command to find out what it does, you
> probably need a style.  `variant' is already use by _pick_variant,
> unfortunately --- it's not a very good name, since it doesn't give the
> variant, it gives the programme to run to pick the variant.  Of course
> it could be set to a function that simply returns the type, but that
> method doesn't have a sensible default.

I just checked this again and _pick_variant doesn't use `variant' as a
style. It sets the tag name to `variant' when looking up the `command'
style. So the `variant' style is not already in use.

Oliver


^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2003-03-19 13:46 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2003-03-14  0:14 Completion and command versions Doug Kearns
2003-03-14 10:30 ` Peter Stephenson
2003-03-14 11:58   ` Oliver Kiddle
2003-03-19 13:45   ` Oliver Kiddle

Code repositories for project(s) associated with this public inbox

	https://git.vuxu.org/mirror/zsh/

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).