Correction Bug in Beta 17

Correction Bug in Beta 17

[Eskandar Ensafi]

Hello,

With the PROMPT_SUBST option set in zsh-2.6-beta17, the spelling correction
prompt is totally messed up, and two bogus error messages are produced:

1% setopt correct
2% setopt promptsubst
3% ks
zsh: unmatched '
zsh: parse error in command substitution
zsh: correct n
zsh: command not found: ks


I should not be getting the "unmatched" and "parse error" messages.  Wasn't
this problem already reported/fixed?  I distinctly recall that someone else
encountered this problem.

With PROMPT_SUBST turned off, everything is normal:

4% unsetopt promptsubst
5% ks
zsh: correct `ks' to `ls' [nyae]? n
zsh: command not found: ks


Later,

- Eskandar

Re: Correction Bug in Beta 17

[Mark Borges]

>> On Wed, 08 May 1996 10:10:12 -0700,
>> Eskandar Ensafi(ee) wrote:
ee> With the PROMPT_SUBST option set in zsh-2.6-beta17, the spelling correction
ee> prompt is totally messed up, and two bogus error messages are produced:

ee> 1% setopt correct
ee> 2% setopt promptsubst
ee> 3% ks
ee> zsh: unmatched '
ee> zsh: parse error in command substitution
ee> zsh: correct n
ee> zsh: command not found: ks

Just as a datapoint, I can't reproduce this:

  $ ~/bin/sunos-5.5/zsh -f
  % echo $ZSH_VERSION
  2.6-beta17
  % setopt correct
  % setopt promptsubst
  % ks
  zsh: Does ks mean ls [nyae]? a
  % uname -a
  SunOS roberts 5.5 Generic_103093-02 sun4m sparc SUNW,SPARCstation-20
  %

compiled with SUNWspro cc-4.0.

-- 
  -mb-

Re: Correction Bug in Beta 17

[Zoltan Hidvegi]

> 
> Hello,
> 
> With the PROMPT_SUBST option set in zsh-2.6-beta17, the spelling correction
> prompt is totally messed up, and two bogus error messages are produced:
> 
> 1% setopt correct
> 2% setopt promptsubst
> 3% ks
> zsh: unmatched '
> zsh: parse error in command substitution
> zsh: correct n
> zsh: command not found: ks

This is not a bug.  And the error messages are correct.  SPROMPT is
initialised to

zsh: correct `%R' to `%r' [nyae]?

If you tund on GLOB_SUBST, zsh will try to expand it so interprets ` as
command substitution.

Zoltan

Re: Correction Bug in Beta 17

[Bart Schaefer]

On May 9, 12:28am, Zoltan Hidvegi wrote:
} Subject: Re: Correction Bug in Beta 17
}
} > With the PROMPT_SUBST option set in zsh-2.6-beta17, the spelling correction
} > prompt is totally messed up, and two bogus error messages are produced:
} > 
} > 1% setopt correct
} > 2% setopt promptsubst
} > 3% ks
} > zsh: unmatched '
} > zsh: parse error in command substitution
} > zsh: correct n
} > zsh: command not found: ks
} 
} This is not a bug.  And the error messages are correct.  SPROMPT is
} initialised to
} 
} zsh: correct `%R' to `%r' [nyae]?
} 
} If you tund on GLOB_SUBST, zsh will try to expand it so interprets ` as
} command substitution.

Sorry, Zoltan, but I'd say that *IS* a bug.  If the initialization of
SPROMPT causes zsh to produce error messages when an option is set,
then I'd say SPROMPT ought not to be initialized to that.  The user
shouldn't have to know that he can't set certain combinations of options
without also changing his prompts.  That's just too silly.

-- 
Bart Schaefer                             Brass Lantern Enterprises
http://www.well.com/user/barts            http://www.nbn.com/people/lantern

Re: Correction Bug in Beta 17

[Peter Stephenson]

hzoli@cs.elte.hu wrote:
> > 1% setopt correct
> > 2% setopt promptsubst
> > 3% ks
> > zsh: unmatched '
> > zsh: parse error in command substitution
> 
> zsh: correct `%R' to `%r' [nyae]?
> 
> If you tund on GLOB_SUBST, zsh will try to expand it so interprets ` as
> command substitution.

Obviously, the default sprompt needs changing; you shouldn't need to
spend several hours debugging just because you've changed your options.

There seems to be another bug hiding here somewhere.

% setopt correct
% ks
zsh: correct 'ks' to 'ms' [nyae]? y
zsh: permission denied: ms
% which ms
% 


*** Src/init.c.gs	Mon May  6 16:08:58 1996
--- Src/init.c	Thu May  9 09:27:32 1996
***************
*** 592,598 ****
  	prompt3 = ztrdup("");
  	prompt4 = ztrdup("");
      }
!     sprompt = ztrdup("zsh: correct `%R' to `%r' [nyae]? ");
  
      if (!(ttystrname = ztrdup(ttyname(SHTTY))))
  	ttystrname = ztrdup("");
--- 592,598 ----
  	prompt3 = ztrdup("");
  	prompt4 = ztrdup("");
      }
!     sprompt = ztrdup("zsh: correct '%R' to '%r' [nyae]? ");
  
      if (!(ttystrname = ztrdup(ttyname(SHTTY))))
  	ttystrname = ztrdup("");

-- 
Peter Stephenson <pws@ifh.de>       Tel: +49 33762 77366
WWW:  http://www.ifh.de/~pws/       Fax: +49 33762 77330
Deutches Electronen-Synchrotron --- Institut fuer Hochenergiephysik Zeuthen
DESY-IfH, 15735 Zeuthen, Germany.

Re: Correction Bug in Beta 17

[Zoltan Hidvegi]

> Obviously, the default sprompt needs changing; you shouldn't need to
> spend several hours debugging just because you've changed your options.
> 
> There seems to be another bug hiding here somewhere.
> 
> % setopt correct
> % ks
> zsh: correct 'ks' to 'ms' [nyae]? y
> zsh: permission denied: ms
> % which ms
> % 

That's not really a bug.  The command hash table contains every file in the
path even non-executable files.

Zoltan

Re: Correction Bug in Beta 17

[Danek Duvall]

-----BEGIN PGP SIGNED MESSAGE-----

On May 8, 11:33, Mark Borges wrote:

>> On Wed, 08 May 1996 10:10:12 -0700,
>> Eskandar Ensafi(ee) wrote:
ee> With the PROMPT_SUBST option set in zsh-2.6-beta17, the spelling correction
ee> prompt is totally messed up, and two bogus error messages are produced:

ee> 1% setopt correct
ee> 2% setopt promptsubst
ee> 3% ks
ee> zsh: unmatched '
ee> zsh: parse error in command substitution
ee> zsh: correct n
ee> zsh: command not found: ks

mb> Just as a datapoint, I can't reproduce this:

I get the same thing as Eskandar under linux.  Libc is 5.2.18, gcc is
2.7.2.  I also get the same behavior under OSF1 3.2, IRIX 5.3, and HPUX
9.05.  Haven't tried under SunOS or Solaris...

Danek

- -- 
Danek Duvall <duvall@lorien.princeton.edu>      PGP keyID: 1024/280CEFB5
Computer Science, Princeton University      F-print: 55 FD E0 AE 19 1C 7D DA
http://lorien.princeton.edu/~duvall/                 E5 D0 56 B2 48 5F A7 A9

-----BEGIN PGP SIGNATURE-----
Version: 2.6.2

iQCVAwUBMZD9GXusfJIoDO+1AQEMxQQAnfDGhFCz8dYBfcRzewEDJsqqUbyttBqo
mjRHrMZIBCpssCpCS+/8kTKfnuNPYpe84tu5AB5wGXm8TZQmsF5NBoh09YSD8nGu
ZOOoIhlb/GTEK0Wvp+gV4QcSfKi9ywx96LG1m20raYiL1daNVftZ6T96d+NyqVU4
jcXGfLvTF+M=
=R5/a
-----END PGP SIGNATURE-----
-----BEGIN PGP SIGNED MESSAGE-----

On May 8, 11:33, Mark Borges wrote:

>> On Wed, 08 May 1996 10:10:12 -0700,
>> Eskandar Ensafi(ee) wrote:
ee> With the PROMPT_SUBST option set in zsh-2.6-beta17, the spelling correction
ee> prompt is totally messed up, and two bogus error messages are produced:

ee> 1% setopt correct
ee> 2% setopt promptsubst
ee> 3% ks
ee> zsh: unmatched '
ee> zsh: parse error in command substitution
ee> zsh: correct n
ee> zsh: command not found: ks

mb> Just as a datapoint, I can't reproduce this:

I get the same thing as Eskandar under linux.  Libc is 5.2.18, gcc is
2.7.2.  I also get the same behavior under OSF1 3.2, IRIX 5.3, and HPUX
9.05.  Haven't tried under SunOS or Solaris...

Danek

- -- 
Danek Duvall <duvall@lorien.princeton.edu>      PGP keyID: 1024/280CEFB5
Computer Science, Princeton University      F-print: 55 FD E0 AE 19 1C 7D DA
http://lorien.princeton.edu/~duvall/                 E5 D0 56 B2 48 5F A7 A9

-----BEGIN PGP SIGNATURE-----
Version: 2.6.2

iQCVAwUBMZD9GXusfJIoDO+1AQEMxQQAnfDGhFCz8dYBfcRzewEDJsqqUbyttBqo
mjRHrMZIBCpssCpCS+/8kTKfnuNPYpe84tu5AB5wGXm8TZQmsF5NBoh09YSD8nGu
ZOOoIhlb/GTEK0Wvp+gV4QcSfKi9ywx96LG1m20raYiL1daNVftZ6T96d+NyqVU4
jcXGfLvTF+M=
=R5/a
-----END PGP SIGNATURE-----