zsh-workers
 help / color / mirror / code / Atom feed
From: Jun T <takimoto-j@kba.biglobe.ne.jp>
To: zsh-workers@zsh.org
Subject: Re: [PATCH 0/3] completion: make: various improvements
Date: Wed, 3 Aug 2022 17:48:43 +0900	[thread overview]
Message-ID: <A66A9E3F-63A2-423E-8C97-16C5F88FB681@kba.biglobe.ne.jp> (raw)
In-Reply-To: <CAMP44s0LaDq_qMqZ1M0UbSBQ9M-2O-s4h-q7q8-XYoBnSv2pfQ@mail.gmail.com>


> 2022/08/03 8:02, Felipe Contreras <felipe.contreras@gmail.com> wrote:
> 
> On Tue, Aug 2, 2022 at 5:43 AM Jun T <takimoto-j@kba.biglobe.ne.jp> wrote:

>> # Not a target:
>> 
>> I think a (wrong) target after this line should be ignored.
> 
> The current code which uses _make-parseMakefile already offers those
> targets anyway, so there is no change.

If 'call-command' style is set to false, then these targets are not
offered (as a possible target).

> Personally I don't like the current design, which is why I don't use
> the official make completion, and use my own instead [1]. I think only
> the targets returned by make should be completed (no _files),

You may try the following:

zstyle ':completion:*:make:*:' tag-order 'targets variables'



  reply	other threads:[~2022-08-03  8:54 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-07-30  1:03 Felipe Contreras
2022-07-30  1:03 ` [PATCH 1/3] completion: make: don't build everything Felipe Contreras
2022-07-30  1:03 ` [PATCH 2/3] completion: make: add a simpler parser Felipe Contreras
2022-07-30  1:03 ` [PATCH 3/3] completion: make: fix whitespaces Felipe Contreras
2022-08-04  8:50   ` Jun T
2022-08-04 15:57     ` Felipe Contreras
2022-08-02 10:42 ` [PATCH 0/3] completion: make: various improvements Jun T
2022-08-02 23:02   ` Felipe Contreras
2022-08-03  8:48     ` Jun T [this message]
2022-08-03 14:36       ` Felipe Contreras
2022-08-04  9:33         ` Jun T
2022-08-04 17:03           ` Felipe Contreras

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=A66A9E3F-63A2-423E-8C97-16C5F88FB681@kba.biglobe.ne.jp \
    --to=takimoto-j@kba.biglobe.ne.jp \
    --cc=zsh-workers@zsh.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.vuxu.org/mirror/zsh/

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).