Re: [PATCH 0/3] completion: make: various improvements

[Felipe Contreras <felipe.contreras@gmail.com>]

On Wed, Aug 3, 2022 at 3:54 AM Jun T <takimoto-j@kba.biglobe.ne.jp> wrote:
>
> > 2022/08/03 8:02, Felipe Contreras <felipe.contreras@gmail.com> wrote:
> >
> > On Tue, Aug 2, 2022 at 5:43 AM Jun T <takimoto-j@kba.biglobe.ne.jp> wrote:
>
> >> # Not a target:
> >>
> >> I think a (wrong) target after this line should be ignored.
> >
> > The current code which uses _make-parseMakefile already offers those
> > targets anyway, so there is no change.
>
> If 'call-command' style is set to false, then these targets are not
> offered (as a possible target).

But if you set it to true they are.

We are talking about the *current code*. The current code already has
this behavior.

> > Personally I don't like the current design, which is why I don't use
> > the official make completion, and use my own instead [1]. I think only
> > the targets returned by make should be completed (no _files),
>
> You may try the following:
>
> zstyle ':completion:*:make:*:' tag-order 'targets variables'

Sure, in that case those files won't be listed initially, but they
still will be completed.

-- 
Felipe Contreras