From: Jun T <takimoto-j@kba.biglobe.ne.jp>
To: zsh-workers@zsh.org
Subject: Re: [PATCH 3/3] completion: make: fix whitespaces
Date: Thu, 4 Aug 2022 17:50:26 +0900 [thread overview]
Message-ID: <473642FA-6178-4DD1-8B97-2250B1EED661@kba.biglobe.ne.jp> (raw)
In-Reply-To: <20220730010310.3383526-4-felipe.contreras@gmail.com>
As this patch shows, _make has some indentation problems
(and also lots of other scripts have them).
> 2022/07/30 10:03, Felipe Contreras <felipe.contreras@gmail.com> write:
>
> diff --git a/Completion/Unix/Command/_make b/Completion/Unix/Command/_make
> @@ -12,35 +12,35 @@ _make-expandVars() {
>
> case $rest[2] in
> ($) # '$$'. may not appear in target and variable's value
> - front=$front\$\$
> - rest=${rest[3,-1]}
> - continue
> - ;;
> + front=$front\$\$
> + rest=${rest[3,-1]}
(snip)
# I didn't know that indent_style for scripts has changed from
# tab to space.
I have a vague memory of argument that it's not good to fix indent of
lines not related with the real fix because it makes 'git blame'
rather useless, and then someone wrote that 'git blame -w' can be used
in that case.
So, in general, is it better (or not) to apply this type of patch?
next prev parent reply other threads:[~2022-08-04 8:55 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-30 1:03 [PATCH 0/3] completion: make: various improvements Felipe Contreras
2022-07-30 1:03 ` [PATCH 1/3] completion: make: don't build everything Felipe Contreras
2022-07-30 1:03 ` [PATCH 2/3] completion: make: add a simpler parser Felipe Contreras
2022-07-30 1:03 ` [PATCH 3/3] completion: make: fix whitespaces Felipe Contreras
2022-08-04 8:50 ` Jun T [this message]
2022-08-04 15:57 ` Felipe Contreras
2022-08-02 10:42 ` [PATCH 0/3] completion: make: various improvements Jun T
2022-08-02 23:02 ` Felipe Contreras
2022-08-03 8:48 ` Jun T
2022-08-03 14:36 ` Felipe Contreras
2022-08-04 9:33 ` Jun T
2022-08-04 17:03 ` Felipe Contreras
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=473642FA-6178-4DD1-8B97-2250B1EED661@kba.biglobe.ne.jp \
--to=takimoto-j@kba.biglobe.ne.jp \
--cc=zsh-workers@zsh.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.vuxu.org/mirror/zsh/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).