From: Julien Nicoulaud <julien.nicoulaud@gmail.com>
To: Oliver Kiddle <okiddle@yahoo.co.uk>
Cc: Mailing-list zsh-workers <zsh-workers@zsh.org>,
"zsh-workers@closedmail.org" <zsh-workers@closedmail.org>
Subject: Re: Fwd: adb pull and push remote completion
Date: Tue, 21 Feb 2017 18:32:53 +0100 [thread overview]
Message-ID: <CA+mcLN5KM399tQBxw-P=mtX35W5_xYQ1XWpgoN6TDJ5912YWCw@mail.gmail.com> (raw)
In-Reply-To: <26668.1487697790@thecus.kiddle.eu>
[-- Attachment #1: Type: text/plain, Size: 1645 bytes --]
Hi Oliver,
2017-02-21 18:23 GMT+01:00 Oliver Kiddle <okiddle@yahoo.co.uk>:
> Julien Nicoulaud wrote:
> >
> > A while ago there was a compdef for adb in https://github.com/zsh-
> > users/zsh-completions, but we deleted it as there was one in zsh:
> > https://github.com/zsh-users/zsh-completions/blob/
> > e70e7f8941d7437a161e3e4bb93f06e9c712c4a4/src/_adb
> >
> > I'm not sure which one is the better one, they probably need merging, but
> > anyway the one in zsh-completions could complete adb push/pull.
> > I hope this can be useful.
>
> A cursory glance at the adb completion in zsh would indicate that, while
> there is plenty of scope for improvement, it is at least attempting to
> complete files on the remote device for push/pull. Without the requisite
> hardware, I can't test it and last time I touched that function I managed
> to accidentally break it so I'm reluctant to change it. Does it not work
> for you?
>
I can't test either, I don't have an Android device anymore.
>
> More generally, whether or not the function in zsh is better or worse,
> it is the one that was contributed to zsh. Personally I'm wary of ever
> picking up functions from github projects and merging their features,
> especially where they have an explicit licence other than the zsh
> licence. In this case it appears that you are the author of the old
> function on github so you'd not have to worry. It might be possible to
> use the _remote_files helper when completing the files.
>
Agreed, I just wanted to give a pointer in case it can be useful.
If anyone wants to work on merging the compdefs the license is not a
problem.
>
> Oliver
>
Julien
prev parent reply other threads:[~2017-02-21 17:34 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-25 9:41 Dov Grobgeld
[not found] ` <CA+mcLN77BVXV26R+NavQfDX8yCjV1CGjzKQx7LZd-E9ZYSE5rw@mail.gmail.com>
2017-02-21 13:20 ` Fwd: " Julien Nicoulaud
2017-02-21 17:23 ` Oliver Kiddle
2017-02-21 17:32 ` Julien Nicoulaud [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CA+mcLN5KM399tQBxw-P=mtX35W5_xYQ1XWpgoN6TDJ5912YWCw@mail.gmail.com' \
--to=julien.nicoulaud@gmail.com \
--cc=okiddle@yahoo.co.uk \
--cc=zsh-workers@closedmail.org \
--cc=zsh-workers@zsh.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.vuxu.org/mirror/zsh/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).