From: Eitan Adler <lists@eitanadler.com>
To: Oliver Kiddle <okiddle@yahoo.co.uk>
Cc: Zsh hackers list <zsh-workers@zsh.org>
Subject: Re: support more arguments to diff
Date: Wed, 18 Apr 2018 02:36:23 -0700 [thread overview]
Message-ID: <CAF6rxgnSmkKCbA8TfcE9zxDBv77uaa91MM0BYOi+6MwV_=8zCg@mail.gmail.com> (raw)
In-Reply-To: <15398.1524043378@thecus>
On 18 April 2018 at 02:22, Oliver Kiddle <okiddle@yahoo.co.uk> wrote:
> Eitan Adler wrote:
>> >> I'd also like to port this particular diff implementation to the other
>> >> BSDs, hence adding all of them to the case statement.
>> >
>> > I think it would be best to add the other cases as each BSD adopts
>> > whichever diff. I generally try to update the completion to match
>> > -current, so when a new release is picked up the options are correct.
>>
>> I also wonder if we could just get rid of the OS test and replace it
>> with a pure version test. What if we run different verrsions than the
>> default?
>
> Yes, detecting the version first is usually best. Arguably, this is what
> we already do with $OSTYPE being a fallback; we have:
>
> _pick_variant -c $cmd gnu=GNU unix -v
>
> Does this new diff produce a helpful signature by which it can be
> identified if run as diff -v
Annoyingly no, but that seems easy to fix.
∴diff -V
diff: invalid option -- V
> I'm not fond of the patch in the form that was posted.
What about just adding FreeBSD then?
> If you want a temporary workaround while using 12-CURRENT, I'd recommend
> setting: _cmd_variant[diff]=gnu
I'll use that for now.
--
Eitan Adler
next prev parent reply other threads:[~2018-04-18 9:36 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-04-16 5:48 Eitan Adler
2018-04-16 14:59 ` Daniel Tameling
2018-04-17 11:22 ` Eitan Adler
2018-04-17 12:53 ` Matthew Martin
2018-04-18 0:37 ` Eitan Adler
2018-04-18 9:22 ` Oliver Kiddle
2018-04-18 9:36 ` Eitan Adler [this message]
2018-08-29 14:56 ` Oliver Kiddle
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAF6rxgnSmkKCbA8TfcE9zxDBv77uaa91MM0BYOi+6MwV_=8zCg@mail.gmail.com' \
--to=lists@eitanadler.com \
--cc=okiddle@yahoo.co.uk \
--cc=zsh-workers@zsh.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.vuxu.org/mirror/zsh/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).