Re: support more arguments to diff

[Eitan Adler <lists@eitanadler.com>]

On 17 April 2018 at 05:53, Matthew Martin <phy1729@gmail.com> wrote:
> On Tue, Apr 17, 2018 at 04:22:38AM -0700, Eitan Adler wrote:
>> On 16 April 2018 at 07:59, Daniel Tameling <tamelingdaniel@gmail.com> wrote:
>> > On Sun, Apr 15, 2018 at 10:48:08PM -0700, Eitan Adler wrote:
>> >> This patch isn't perfect since {Net,DragonFly,Open,Free}BSD are not
>> >> identical but this patch at leasts makes the completion a lot closer
>> >> to reality.
>> >>
>> >> Currently FreeBSD doesn't even show -q for example.
>> >>
>> >
>> > Did the patch change the behavior of diff completion for you? On my
>> > FreeBSD, diff is some GNU variant, and I think that it's the default
>> > and that I didn't install it via pkg:
>>
>> FreeBSD is in the process of converting to a new diff implementation.
>> This resulted in me seeing a huge difference with this patch.
>>
>> I'd also like to port this particular diff implementation to the other
>> BSDs, hence adding all of them to the case statement.
>
> I think it would be best to add the other cases as each BSD adopts
> whichever diff. I generally try to update the completion to match
> -current, so when a new release is picked up the options are correct.

I also wonder if we could just get rid of the OS test and replace it
with a pure version test. What if we run different verrsions than the
default?


-- 
Eitan Adler