From: Bart Schaefer <schaefer@brasslantern.com>
To: Philippe Altherr <philippe.altherr@gmail.com>
Cc: zsh-workers@zsh.org
Subject: Re: [PATCH] More ERR_EXIT (was Re: Tests RE behavior of ERR_EXIT)
Date: Sun, 13 Nov 2022 08:52:12 -0800 [thread overview]
Message-ID: <CAH+w=7Y3n=PD09HZqaexzTUfhxDOmGfV8y-qSJFfKfNrAmUNwQ@mail.gmail.com> (raw)
In-Reply-To: <CAGdYchv9wNqhBEFLp88tetb+YCxtd2aUSVZhuTAyTJqZz5cLww@mail.gmail.com>
On Sun, Nov 13, 2022 at 7:46 AM Philippe Altherr
<philippe.altherr@gmail.com> wrote:
>
> Now let's remove the following code from exec.c
>
>> if (!(oldnoerrexit & NOERREXIT_UNTIL_EXEC))
>> noerrexit = oldnoerrexit;
>
>
> With that change the two functions still behave exactly the same but if you replace the while statement with any other statement (if, case, for, ...) then no ERR_EXIT is triggered in foo. Instead the non-zero exit status correctly bubbles up to the caller and triggers an ERR_EXIT in bar.
>
> I still don't understand why the change above fixes the problem for if, case, for, ... statements. I understand even less why it doesn't fix it for while statements.
NOERREXIT_UNTIL_EXEC is what protects the tests between keywords "if"
and "then" and those between "while" and "do" from triggering
ERR_EXIT.
The problem is that when an && || conditional expression appears
between "then" and "fi" or between "do" and "done" the assignment of
noerrexit = olderrexit still happens, which resets the state too far
into the past.
next prev parent reply other threads:[~2022-11-13 16:52 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-12 22:16 Philippe Altherr
2022-11-13 3:59 ` Philippe Altherr
2022-11-13 4:11 ` Bart Schaefer
2022-11-13 13:55 ` Philippe Altherr
2022-11-13 14:24 ` Philippe Altherr
2022-11-13 15:45 ` Philippe Altherr
2022-11-13 16:52 ` Bart Schaefer [this message]
2022-11-13 16:45 ` Bart Schaefer
2022-11-13 16:53 ` Bart Schaefer
2022-11-13 18:37 ` Philippe Altherr
2022-11-13 20:55 ` Philippe Altherr
2022-11-13 22:27 ` Bart Schaefer
2022-11-13 23:10 ` Lawrence Velázquez
2022-11-13 22:12 ` Bart Schaefer
2022-11-15 1:11 ` Bart Schaefer
2022-11-15 7:01 ` [PATCH] Even more ERR_EXIT (was Re: More ERR_EXIT " Bart Schaefer
2022-11-15 7:30 ` Philippe Altherr
2022-11-15 19:50 ` Philippe Altherr
2022-11-15 7:26 ` [PATCH] More ERR_EXIT (was " Philippe Altherr
2022-11-15 19:18 ` Philippe Altherr
2022-11-15 21:08 ` Bart Schaefer
2022-11-16 2:41 ` Lawrence Velázquez
2022-11-16 6:31 ` Philippe Altherr
2022-11-16 5:51 ` Bart Schaefer
2022-11-16 7:56 ` Philippe Altherr
2022-11-16 14:21 ` Philippe Altherr
-- strict thread matches above, loose matches on Subject: below --
2022-11-09 5:29 Tests RE behavior of ERR_EXIT Bart Schaefer
2022-11-10 5:22 ` [PATCH] More ERR_EXIT (was Re: Tests RE behavior of ERR_EXIT) Bart Schaefer
2022-11-10 5:47 ` Bart Schaefer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAH+w=7Y3n=PD09HZqaexzTUfhxDOmGfV8y-qSJFfKfNrAmUNwQ@mail.gmail.com' \
--to=schaefer@brasslantern.com \
--cc=philippe.altherr@gmail.com \
--cc=zsh-workers@zsh.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.vuxu.org/mirror/zsh/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).