From: Bart Schaefer <schaefer@brasslantern.com>
To: Philippe Altherr <philippe.altherr@gmail.com>
Cc: zsh-workers@zsh.org
Subject: Re: [PATCH] More ERR_EXIT (was Re: Tests RE behavior of ERR_EXIT)
Date: Sat, 12 Nov 2022 20:11:01 -0800 [thread overview]
Message-ID: <CAH+w=7YD3jXE5Yy+J-dQVNVeJagHPH6HeFsavKjzAPJyaGDGWA@mail.gmail.com> (raw)
In-Reply-To: <CAGdYchu66aYu+3yzYGtMnNcT6GcWziWe9YWNqOv5_T=JpCynRg@mail.gmail.com>
On Sat, Nov 12, 2022 at 7:59 PM Philippe Altherr
<philippe.altherr@gmail.com> wrote:
>
> - The problem seems to be related to how "false && true" interacts with other constructs.
> - In Zsh 5.9 the problem seems to be that compound commands now incorrectly trigger ERR_EXIT.
> - In Zsh 5.8 I can't pinpoint the problem, for now.
You shouldn't even be bothering with 5.8.1, it's been wrong all along;
it blindly never errexits at the end of an if/then/fi.
I think my patches so far have uncovered a different bug that was
already present but was masked by the foregoing, which is, that
noerrexit is unwound in cases where it should not be. I think this is
happening at lines 1530-1531 of exec.c, right under the comment about
"hairy code near the end of execif()". That's an area I didn't touch,
but I'm pretty sure it's restoring noerrexit to its state before
entering the "if" (oldnoerrexit) when it should be preserving the
state from the "&&" conditional. In 5.8.1 this gets reversed again
via this_noerrexit.
next prev parent reply other threads:[~2022-11-13 4:11 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-12 22:16 Philippe Altherr
2022-11-13 3:59 ` Philippe Altherr
2022-11-13 4:11 ` Bart Schaefer [this message]
2022-11-13 13:55 ` Philippe Altherr
2022-11-13 14:24 ` Philippe Altherr
2022-11-13 15:45 ` Philippe Altherr
2022-11-13 16:52 ` Bart Schaefer
2022-11-13 16:45 ` Bart Schaefer
2022-11-13 16:53 ` Bart Schaefer
2022-11-13 18:37 ` Philippe Altherr
2022-11-13 20:55 ` Philippe Altherr
2022-11-13 22:27 ` Bart Schaefer
2022-11-13 23:10 ` Lawrence Velázquez
2022-11-13 22:12 ` Bart Schaefer
2022-11-15 1:11 ` Bart Schaefer
2022-11-15 7:01 ` [PATCH] Even more ERR_EXIT (was Re: More ERR_EXIT " Bart Schaefer
2022-11-15 7:30 ` Philippe Altherr
2022-11-15 19:50 ` Philippe Altherr
2022-11-15 7:26 ` [PATCH] More ERR_EXIT (was " Philippe Altherr
2022-11-15 19:18 ` Philippe Altherr
2022-11-15 21:08 ` Bart Schaefer
2022-11-16 2:41 ` Lawrence Velázquez
2022-11-16 6:31 ` Philippe Altherr
2022-11-16 5:51 ` Bart Schaefer
2022-11-16 7:56 ` Philippe Altherr
2022-11-16 14:21 ` Philippe Altherr
-- strict thread matches above, loose matches on Subject: below --
2022-11-09 5:29 Tests RE behavior of ERR_EXIT Bart Schaefer
2022-11-10 5:22 ` [PATCH] More ERR_EXIT (was Re: Tests RE behavior of ERR_EXIT) Bart Schaefer
2022-11-10 5:47 ` Bart Schaefer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAH+w=7YD3jXE5Yy+J-dQVNVeJagHPH6HeFsavKjzAPJyaGDGWA@mail.gmail.com' \
--to=schaefer@brasslantern.com \
--cc=philippe.altherr@gmail.com \
--cc=zsh-workers@zsh.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.vuxu.org/mirror/zsh/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).