From: Bart Schaefer <schaefer@brasslantern.com>
To: Marlon Richert <marlon.richert@gmail.com>
Cc: Zsh hackers list <zsh-workers@zsh.org>
Subject: Re: Proposal: Let compinit make standard widgets with _generic instead of _main_complete
Date: Sun, 4 Apr 2021 11:35:54 -0700 [thread overview]
Message-ID: <CAH+w=7YAxLGd=cTFkOqHXiUpk1iPp=7u3-qvEKmE6dTSELcoMA@mail.gmail.com> (raw)
In-Reply-To: <CAHLkEDuo=8MbjYWOmQM5d4uLOzo+BC6XTy=S14-BfeBPMZjysw@mail.gmail.com>
On Mon, Mar 22, 2021 at 12:17 AM Marlon Richert
<marlon.richert@gmail.com> wrote:
>
> On Sun, Mar 21, 2021 at 1:53 AM Bart Schaefer <schaefer@brasslantern.com> wrote:
> > +if [[ "${curcontext:-:::}" == ::: ]] &&
> > + zstyle -t ":completion:::::" generic-widgets "$WIDGET"
> > +then
> > + _generic "$@"
> > + return
> > +fi
>
> This feels like a rather roundabout solution. _generic itself already
> checks whether $curcontext is set and then calls _main_complete. Why
> not just do the straightforward thing, and let the widget call
> _generic directly, which in turn will call _main_complete anyway?
This is really only the first in a few steps of patch that I didn't
want to spend time on if this were rejected out of hand.
The problem with calling _generic at all (right now) is that it messes
with $curcontext in a way that may break other functions that rely on
_main_complete behavior. If we can invert the call sequence so
_main_complete remains first, then _generic itself can be tweaked so
that it does NOT mung the context in that circumstance, while still
leaving the original semantics of creating a new widget with _generic
unchanged.
next prev parent reply other threads:[~2021-04-04 18:36 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-19 22:23 Marlon Richert
2021-03-20 18:09 ` Bart Schaefer
2021-03-20 23:52 ` Bart Schaefer
2021-03-21 15:19 ` Marlon Richert
2021-03-22 1:46 ` Bart Schaefer
2021-03-22 7:16 ` Marlon Richert
2021-04-03 19:37 ` Lawrence Velázquez
2021-04-04 18:35 ` Bart Schaefer [this message]
2021-04-04 19:31 ` Bart Schaefer
2021-04-09 19:11 ` Oliver Kiddle
2021-04-09 19:35 ` Bart Schaefer
2021-05-09 20:51 ` Lawrence Velázquez
2021-05-10 17:11 ` Bart Schaefer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAH+w=7YAxLGd=cTFkOqHXiUpk1iPp=7u3-qvEKmE6dTSELcoMA@mail.gmail.com' \
--to=schaefer@brasslantern.com \
--cc=marlon.richert@gmail.com \
--cc=zsh-workers@zsh.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.vuxu.org/mirror/zsh/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).