From: Bart Schaefer <schaefer@brasslantern.com>
To: Daniel Shahaf <d.s@daniel.shahaf.name>
Cc: Marlon Richert <marlon.richert@gmail.com>,
Zsh hackers list <zsh-workers@zsh.org>
Subject: Re: [RFC] Add xfail tests for || form of completion matchers
Date: Tue, 12 Oct 2021 22:08:35 -0700 [thread overview]
Message-ID: <CAH+w=7YTn=aQU6qPa7ih7dObfKo1tbFfDirRoEzdmc3vY58eNg@mail.gmail.com> (raw)
In-Reply-To: <20211012152532.GC17948@tarpaulin.shahaf.local2>
On Tue, Oct 12, 2021 at 8:26 AM Daniel Shahaf <d.s@daniel.shahaf.name> wrote:
>
> Marlon Richert wrote on Tue, Oct 12, 2021 at 15:08:46 +0300:
> > On Mon, Oct 11, 2021 at 5:34 PM Marlon Richert <marlon.richert@gmail.com> wrote:
> > >
> > > The tests show how :||= matchers should behave in order to provide
> > > completion features that cannot be implemented with :|= matchers.
>
> Would this be backwards compatible?
In particular, with the exception of specific bug regression tests,
all the tests using || matchers have been converted to xfails.
Shouldn't there still be some generic tests of the (functionally
correct subset of) the current behavior of || ? And, do you think any
of the regression tests would begin to fail if the xfail tests begin
to succeed?
next prev parent reply other threads:[~2021-10-13 5:09 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-11 14:34 Marlon Richert
2021-10-12 12:08 ` Marlon Richert
2021-10-12 15:25 ` Daniel Shahaf
2021-10-13 4:57 ` Bart Schaefer
2021-10-13 5:08 ` Bart Schaefer [this message]
2021-10-13 14:20 ` Marlon Richert
2021-10-13 19:37 ` Daniel Shahaf
2021-10-13 20:02 ` Bart Schaefer
2021-10-14 20:25 ` Oliver Kiddle
2021-10-14 20:43 ` Oliver Kiddle
2021-10-14 21:16 ` Bart Schaefer
2021-10-22 13:02 ` Oliver Kiddle
2021-10-25 18:41 ` Marlon Richert
2021-10-25 19:41 ` Bart Schaefer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAH+w=7YTn=aQU6qPa7ih7dObfKo1tbFfDirRoEzdmc3vY58eNg@mail.gmail.com' \
--to=schaefer@brasslantern.com \
--cc=d.s@daniel.shahaf.name \
--cc=marlon.richert@gmail.com \
--cc=zsh-workers@zsh.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.vuxu.org/mirror/zsh/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).