From: Bart Schaefer <schaefer@brasslantern.com>
To: Peter Stephenson <p.w.stephenson@ntlworld.com>
Cc: "zsh-workers@zsh.org" <zsh-workers@zsh.org>
Subject: Re: Feature request: ZSH_XTRACEFD variable
Date: Tue, 5 May 2020 15:19:05 -0700 [thread overview]
Message-ID: <CAH+w=7YpEEy-H8tXt6toaC3gNQ95SAgjGJ=_n5_+XwXCchC3+Q@mail.gmail.com> (raw)
In-Reply-To: <600054363.204367.1588697277901@mail2.virginmedia.com>
(Peter, for some reason Gmail is classifying all email from
ntlworld.com as spam, with the notation that it "can't guarantee that
this message came from ntlworld.com")
On Tue, May 5, 2020 at 9:48 AM Peter Stephenson
<p.w.stephenson@ntlworld.com> wrote:
>
>
> The problem is if we fopen() the file descriptor to use stdio as output, we can either
> leak the entire FILE, not opened by the user, or we can close the entire FILE.
In that case we should be doing the fopen() on a dup() of the
descriptor, and fclose()ing the FILE.
If it is important that fileno(xtrerr) == $ZSH_XTRACEFD, then we should
1) dup() the descriptor to save a copy
2) fopen() the original
3) after fclose(), dup2() the copy back to the original
4) close() the copy
However, I'm not sure it's necessary to be that convoluted.
next prev parent reply other threads:[~2020-05-05 22:20 UTC|newest]
Thread overview: 37+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-17 15:08 Timothée Mazzucotelli
2019-05-18 7:55 ` Stephane Chazelas
2019-05-20 10:34 ` Stephane Chazelas
2019-07-21 15:08 ` Timothée Mazzucotelli
2019-07-21 15:22 ` Peter Stephenson
2019-07-31 19:40 ` Timothée Mazzucotelli
2019-07-31 19:45 ` Timothée Mazzucotelli
2019-07-31 21:12 ` Sebastian Gniazdowski
2019-08-13 9:14 ` Peter Stephenson
2019-08-13 15:38 ` Peter Stephenson
2019-09-10 22:19 ` Timothée Mazzucotelli
2019-09-11 8:45 ` Peter Stephenson
2020-04-19 10:30 ` Timothée Mazzucotelli
2020-04-20 14:09 ` Peter Stephenson
2020-05-02 18:02 ` Timothée Mazzucotelli
2020-05-02 21:15 ` Bart Schaefer
2020-05-03 0:06 ` Daniel Shahaf
2020-05-03 4:43 ` Roman Perepelitsa
2020-05-03 16:21 ` Daniel Shahaf
2020-05-03 19:54 ` Peter Stephenson
2020-05-03 21:06 ` Daniel Shahaf
2020-05-04 8:35 ` Peter Stephenson
2020-05-05 0:03 ` Daniel Shahaf
2020-05-05 16:36 ` Timothée Mazzucotelli
2020-05-05 16:47 ` Peter Stephenson
2020-05-05 22:19 ` Bart Schaefer [this message]
2020-09-03 13:51 ` Timothée Mazzucotelli
2020-09-04 19:48 ` Daniel Shahaf
2020-09-04 19:53 ` Bart Schaefer
2020-09-05 9:24 ` Timothée Mazzucotelli
2020-05-05 22:11 ` Bart Schaefer
2020-05-03 6:01 ` Stephane Chazelas
2020-05-03 7:07 ` Stephane Chazelas
2020-05-03 17:30 ` Peter Stephenson
2020-05-03 21:23 ` Daniel Shahaf
2020-05-04 8:26 ` Peter Stephenson
2020-05-05 20:50 ` Daniel Shahaf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAH+w=7YpEEy-H8tXt6toaC3gNQ95SAgjGJ=_n5_+XwXCchC3+Q@mail.gmail.com' \
--to=schaefer@brasslantern.com \
--cc=p.w.stephenson@ntlworld.com \
--cc=zsh-workers@zsh.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.vuxu.org/mirror/zsh/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).