From: Bart Schaefer <schaefer@brasslantern.com>
To: Daniel Shahaf <d.s@daniel.shahaf.name>
Cc: "zsh-workers@zsh.org" <zsh-workers@zsh.org>
Subject: Re: "set -e" handling is broken with zsh 5.3.1 and 5.4.1
Date: Sun, 27 Aug 2017 23:45:20 -0700 [thread overview]
Message-ID: <CAH+w=7aEOC1sT94Lzko7xy-fSFy0R_RL09bXPWn79gVF+yN0UA@mail.gmail.com> (raw)
In-Reply-To: <1503883531.3929330.1086829200.165C21BC@webmail.messagingengine.com>
On Sun, Aug 27, 2017 at 6:25 PM, Daniel Shahaf <d.s@daniel.shahaf.name> wrote:
> Vincent Lefevre wrote on Mon, 28 Aug 2017 00:26 +0200:
>> Perhaps it was needed in the past, and no longer makes sense now.
>> Have you looked at the diff that introduced it,
>
> It's this one:
>
> commit d6a32ddeed914434f5b56b013c9d03b28781d065
> Author: Barton E. Schaefer <schaefer@zsh.org>
> Date: Sat Dec 27 21:55:58 2014 -0800
>
> 34065: following an "if" condition, do not test lastval for ERR_EXIT until a new command is run
Background is in workers/34055 and 34059, and this looks to have
something to do with noerrexit not propagating into the first sublist
in a function body. It's entirely possible that the change from
having a few numeric values for the flags to have a set of bit values
has made that test unnecessary, or it may be needed in case that
hasn't been tested yet -- the original report in 34055 involves
calling a function within an if/else block.
next prev parent reply other threads:[~2017-08-28 6:45 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-08-27 0:50 Vincent Lefevre
2017-08-27 1:30 ` Daniel Shahaf
2017-08-27 1:46 ` Vincent Lefevre
2017-08-27 18:56 ` Peter Stephenson
2017-08-27 22:26 ` Vincent Lefevre
2017-08-28 1:25 ` Daniel Shahaf
2017-08-28 6:45 ` Bart Schaefer [this message]
2017-08-28 20:56 ` Peter Stephenson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAH+w=7aEOC1sT94Lzko7xy-fSFy0R_RL09bXPWn79gVF+yN0UA@mail.gmail.com' \
--to=schaefer@brasslantern.com \
--cc=d.s@daniel.shahaf.name \
--cc=zsh-workers@zsh.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.vuxu.org/mirror/zsh/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).