From: Marlon Richert <marlon.richert@gmail.com>
To: Mikael Magnusson <mikachu@gmail.com>
Cc: "Lawrence Velázquez" <larryv@zsh.org>,
"Zsh hackers list" <zsh-workers@zsh.org>
Subject: Re: [PATCH] Improve extra-verbose completion of array params
Date: Sun, 16 May 2021 22:40:51 +0300 [thread overview]
Message-ID: <CAHLkEDtCEZJ_hDnaGu6btBj58ftT6P0Jjk4PniSjPaFiWH-JVw@mail.gmail.com> (raw)
In-Reply-To: <CAHYJk3QrakRLRrpektmV42NB9M--U+xne3SSDKH8hqdJ5v3yng@mail.gmail.com>
On Sun, May 16, 2021 at 7:18 PM Mikael Magnusson <mikachu@gmail.com> wrote:
>
> On 5/16/21, Lawrence Velázquez <larryv@zsh.org> wrote:
> > On Sun, May 9, 2021, at 1:47 PM, Lawrence Velázquez wrote:
> >> On Tue, Apr 27, 2021, at 6:28 AM, Marlon Richert wrote:
> >> > This patch improves the extra-verbose completion display strings for
> >> > arrays and associative arrays.
> >>
> >> ping for review
> >
> > Ping II: The Sequel
>
> I looked at the patch but there is no description of what the intent
> is, so it is impossible for me to say if it achieves it. The code
> itself is not exactly self-explanatory...
I thought the test changes included made it rather self-explanatory:
0:extra-verbose shows parameter values
>line: {: $ba}{}
>DESCRIPTION:{parameter}
->NO:{bar -- '^@' '^A' '^B' '^C' '^D' '^E' '^F' '^G' '^H' '\t' '\n'
'^K' '^L' '^M}
->NO:{baz -- '^@ ^A ^B ^C ^D ^E ^F ^G ^H \t \n ^K ^L ^M ^N ^O ^P ^Q
^R ^S ^T ^U ^}
+>NO:{bar -- ( '^@' '^A' '^B' '^C' '^D' '^E' '^F' '^G' '^H' '\t' '\n'
'^K' '^L' '}
+>NO:{bat -- ( [' ']='!' ['"']='#' ['$']=% ['&']=\' ['(']=')' ['*']=+
[,]=- [.]=/}
+>NO:{bay -- '^@ ^A ^B ^C ^D ^E ^F ^G ^H \t \n ^K ^L ^M ^N ^O ^P ^Q
^R ^S ^T ^U ^}
When using extra-verbose parameter completion, you can now clearly see
the difference between the values of scalars, arrays and associative
arrays.
How about if I change the commit message? Perhaps something like this:
Improve formatting of array values in extra-verbose parameter completion
Make it more visually obvious which values are arrays or
associative arrays."
Would that help? I'm open to suggestions.
next prev parent reply other threads:[~2021-05-16 19:41 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-27 10:28 Marlon Richert
2021-05-09 17:47 ` Lawrence Velázquez
2021-05-16 16:12 ` Lawrence Velázquez
2021-05-16 16:18 ` Mikael Magnusson
2021-05-16 19:40 ` Marlon Richert [this message]
2021-05-16 22:09 ` Oliver Kiddle
2021-05-17 11:58 ` Marlon Richert
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAHLkEDtCEZJ_hDnaGu6btBj58ftT6P0Jjk4PniSjPaFiWH-JVw@mail.gmail.com \
--to=marlon.richert@gmail.com \
--cc=larryv@zsh.org \
--cc=mikachu@gmail.com \
--cc=zsh-workers@zsh.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.vuxu.org/mirror/zsh/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).