From: Marlon Richert <marlon.richert@gmail.com>
To: Zsh hackers list <zsh-workers@zsh.org>
Subject: region_highlight converts `fg=default` to `none`, which is not the same
Date: Mon, 12 Oct 2020 12:22:43 +0300 [thread overview]
Message-ID: <CAHLkEDv9ch+nhtpYF3So+029J6GMv5iU-8=RzHRHLa7OYzc3kg@mail.gmail.com> (raw)
[-- Attachment #1: Type: text/plain, Size: 1541 bytes --]
Hi there, devs!
I am using `zsh-syntax-highlighting` and I want my paths to be blue, but
the slashes in there to be my terminal's default text color. I've tested it
and `zsh-syntax-highlighting` correctly puts, for example,
```
region_highlight=( '0 2 fg=10' '3 16 fg=4' '3 4 fg=default' '9 10
fg=default' )
```
where `3 16` is the path I'm trying to `cd` to and `3 4` plus `9 10` are
the positions of slashes in the path.
However, after this assignment occurs, when I `print -r
"${(q+)region_highlight[@]}"`, I get as output
```
'0 2 fg=10' '3 16 fg=4' '3 4 none' '9 10 none'
```
and when the ZLE highlights the line, the slashes are rendered in the same
blue color as the rest of the path. If I use any other `fg` value than `
default`, then the slashes are colored correctly.
This seems like incorrect behavior to me, on two accounts:
1. It seems incorrect to convert `fg=default` to `none`. From reading the
[documentation](
http://zsh.sourceforge.net/Doc/Release/Zsh-Line-Editor.html#Character-Highlighting),
`none` is not supposed to be the same as `fg=default`.
2. It also seems incorrect to me that `none` effectively does nothing at
all. According to the documentation, `none` should mean that
> No highlighting is applied to the given context.
Instead, `none` just appears to do nothing at all, which seems useless
to me; if I don't want to change the highlighting of that part of the line,
then I can just not add a spec for it.
Do you agree and could someone be so kind as to fix this? :)
Cheers,
Marlon
[-- Attachment #2: Type: text/html, Size: 2698 bytes --]
next reply other threads:[~2020-10-12 9:23 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-12 9:22 Marlon Richert [this message]
2020-10-13 11:05 ` Roman Perepelitsa
2020-10-14 5:12 ` Marlon Richert
2020-10-14 20:46 ` Daniel Shahaf
2020-10-15 7:37 ` Roman Perepelitsa
2020-10-15 16:58 ` Marlon Richert
2020-10-15 17:09 ` Roman Perepelitsa
2020-10-16 13:36 ` Daniel Shahaf
2020-10-24 1:34 ` Oliver Kiddle
2020-10-24 6:42 ` Roman Perepelitsa
2020-10-16 13:28 ` Daniel Shahaf
2020-10-16 15:50 ` Bart Schaefer
2020-10-22 19:58 ` Marlon Richert
2020-10-22 23:28 ` Daniel Shahaf
2020-10-23 8:08 ` Roman Perepelitsa
2020-10-23 9:24 ` Marlon Richert
2020-10-23 9:35 ` Roman Perepelitsa
2020-10-23 10:40 ` Marlon Richert
2020-10-23 11:38 ` Roman Perepelitsa
2020-10-24 0:50 ` Functions/Misc/colors vs. region_highlight Bart Schaefer
2020-11-03 18:54 ` Marlon Richert
2020-11-03 23:45 ` Bart Schaefer
2020-11-04 15:47 ` Marlon Richert
2021-04-18 21:40 ` Bart Schaefer
2020-10-23 23:57 ` Threading across year boundaries (was: Re: region_highlight converts `fg=default` to `none`, which is not the same) Daniel Shahaf
2021-03-31 8:26 ` region_highlight converts `fg=default` to `none`, which is not the same Marlon Richert
2021-04-10 20:33 ` Lawrence Velázquez
2021-04-13 15:20 ` Daniel Shahaf
2021-04-13 20:33 ` Roman Perepelitsa
2021-04-14 11:04 ` Daniel Shahaf
2021-05-09 20:49 ` Lawrence Velázquez
2021-05-31 1:16 ` Lawrence Velázquez
2021-03-31 8:24 ` Marlon Richert
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAHLkEDv9ch+nhtpYF3So+029J6GMv5iU-8=RzHRHLa7OYzc3kg@mail.gmail.com' \
--to=marlon.richert@gmail.com \
--cc=zsh-workers@zsh.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.vuxu.org/mirror/zsh/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).