From: "Daniel Shahaf" <d.s@daniel.shahaf.name>
To: "Roman Perepelitsa" <roman.perepelitsa@gmail.com>
Cc: "Marlon Richert" <marlon.richert@gmail.com>,
"Zsh hackers list" <zsh-workers@zsh.org>
Subject: Re: region_highlight converts `fg=default` to `none`, which is not the same
Date: Fri, 16 Oct 2020 13:28:35 +0000 [thread overview]
Message-ID: <cd3c7101-2735-4e4e-a40f-76d0850f471d@www.fastmail.com> (raw)
In-Reply-To: <CAN=4vMqencidrpknTheyjAYQRT9BHN8ZLXRFk2Z38Gfwx9mxyQ@mail.gmail.com>
Roman Perepelitsa wrote on Thu, 15 Oct 2020 07:37 +00:00:
> I could imagine two simple merging strategies:
>
> 1. All attributes are merged, so fg=1 + bg=2 + underline would result
> in underlined red text on green background.
> 2. The second highlight completely overrides the first. fg=1 + bg=2 +
> underline results in underlined text with the default color and no
> background.
>
> The meaning of "none" naturally follows from the choice of merging
> strategy. In the first case region highlight with "none" spec has no
> effect (X + none => X). In the second case such a region is displayed
> without any highlighting (X + none => no highlighting).
>
> The actual code does something else. If a spec has fg or bg with any
> value other than "default", then the spec completely overrides the
> previous spec. Otherwise the spec is merged with the previous spec
> with one exception: fg=default and bg=default have no effect (fg=1 +
> fg=default,underline => fg=1,underline).
>
> Note: "special" highlight is merged with a different algorithm. All
> other highlights, including "region", "isearch" and "paste", are
> merged the same way as the elements of region_highlights.
>
> A few examples of what the current code does:
>
> - fg=1 + bg=2 => bg=2
> * the second spec completely overrides the first
> - fg=1 + underline => fg=1,underline
> * specs are merged
> - underline + fg=1 => fg=1
> * the second spec completely overrides the first
> - fg=1 + none => fg=1
> * specs are merged
> - fg=1 + fg=default,underline => fg=1,underline
> * specs are merged except that fg=default has no effect
>
> This doesn't look ideal. So, how can we fix it?
⋮
> Thoughts?
The inconsistent augmentation semantics have bugged me since I first ran
into them. I'd love to see them rationalized.
Short on time, but in general terms:
1. Heed PEP 20. (E.g., the points about explicitness and ambiguity)
2. Proposed acceptance test: When two specs are added, A+B, for any
desired visual outcome there should be a value of B that, _regardless
of the value of A_, achieves that outcome.
Not sure how to get from the current semantics to acceptable ones. Maybe we could do, say:
- fg=1 + bg=2,fg=inherit ⇒ fg=1,bg=2
- underline + fg=1,underline=inherit ⇒ fg=1,underline
- none + fg=1,underline=inherit ⇒ fg=1 [no underline]
As to «fg=1 + fg=default ⇒ fg=1», I think we can treat it as a bug and break compatibility?
next prev parent reply other threads:[~2020-10-16 13:29 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-12 9:22 Marlon Richert
2020-10-13 11:05 ` Roman Perepelitsa
2020-10-14 5:12 ` Marlon Richert
2020-10-14 20:46 ` Daniel Shahaf
2020-10-15 7:37 ` Roman Perepelitsa
2020-10-15 16:58 ` Marlon Richert
2020-10-15 17:09 ` Roman Perepelitsa
2020-10-16 13:36 ` Daniel Shahaf
2020-10-24 1:34 ` Oliver Kiddle
2020-10-24 6:42 ` Roman Perepelitsa
2020-10-16 13:28 ` Daniel Shahaf [this message]
2020-10-16 15:50 ` Bart Schaefer
2020-10-22 19:58 ` Marlon Richert
2020-10-22 23:28 ` Daniel Shahaf
2020-10-23 8:08 ` Roman Perepelitsa
2020-10-23 9:24 ` Marlon Richert
2020-10-23 9:35 ` Roman Perepelitsa
2020-10-23 10:40 ` Marlon Richert
2020-10-23 11:38 ` Roman Perepelitsa
2020-10-24 0:50 ` Functions/Misc/colors vs. region_highlight Bart Schaefer
2020-11-03 18:54 ` Marlon Richert
2020-11-03 23:45 ` Bart Schaefer
2020-11-04 15:47 ` Marlon Richert
2021-04-18 21:40 ` Bart Schaefer
2020-10-23 23:57 ` Threading across year boundaries (was: Re: region_highlight converts `fg=default` to `none`, which is not the same) Daniel Shahaf
2021-03-31 8:26 ` region_highlight converts `fg=default` to `none`, which is not the same Marlon Richert
2021-04-10 20:33 ` Lawrence Velázquez
2021-04-13 15:20 ` Daniel Shahaf
2021-04-13 20:33 ` Roman Perepelitsa
2021-04-14 11:04 ` Daniel Shahaf
2021-05-09 20:49 ` Lawrence Velázquez
2021-05-31 1:16 ` Lawrence Velázquez
2021-03-31 8:24 ` Marlon Richert
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cd3c7101-2735-4e4e-a40f-76d0850f471d@www.fastmail.com \
--to=d.s@daniel.shahaf.name \
--cc=marlon.richert@gmail.com \
--cc=roman.perepelitsa@gmail.com \
--cc=zsh-workers@zsh.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.vuxu.org/mirror/zsh/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).