Bug in syntax check

Bug in syntax check

[Felipe Contreras]

[-- Attachment #1: Type: text/plain, Size: 524 bytes --]

Hi,

The following script works fine, but when run with 'zsh -n' the syntax
checker returns an error:

6: no such user or named directory: tmp

Ideally the checker should know that the named directory was set in the
same script (it doesn't check the ones in the environment either), but at
the very least it shouldn't check the named directories at all.

It's better to not check anything that throw bad errors.

Cheers.

---

#!/bin/zsh

emulate sh

hash -d tmp=/tmp
hash -d test=~tmp/test

echo ~test
-- 
Felipe Contreras

Re: Bug in syntax check

[Bart Schaefer]

On Jun 4,  5:13am, Felipe Contreras wrote:
} 
} The following script works fine, but when run with 'zsh -n' the syntax
} checker returns an error:
} 
} 6: no such user or named directory: tmp


diff --git a/Src/subst.c b/Src/subst.c
index 4e13ce1..8e704b1 100644
--- a/Src/subst.c
+++ b/Src/subst.c
@@ -691,7 +691,7 @@ filesubstr(char **namptr, int assign)
 		return 0;
 	    *ptr = 0;
 	    if (!(hom = getnameddir(++str))) {
-		if (isset(NOMATCH))
+		if (isset(NOMATCH) && isset(EXECOPT))
 		    zerr("no such user or named directory: %s", str);
 		*ptr = save;
 		return 0;

Re: Bug in syntax check

[Bart Schaefer]

On Jun 4,  5:13am, Felipe Contreras wrote:
}
} It's better to not check anything that throw bad errors.

Incidentally, how are you managing to get NOMATCH and NOEXEC set at
the same time?  NOMATCH is not a default option and NOEXEC should be
preventing any setopt calls from changing that.

Re: Bug in syntax check

[Felipe Contreras]

[-- Attachment #1: Type: text/plain, Size: 556 bytes --]

On Sat, Jun 4, 2016 at 1:50 AM Bart Schaefer <schaefer@brasslantern.com>
wrote:

> On Jun 4,  5:13am, Felipe Contreras wrote:
> }
> } It's better to not check anything that throw bad errors.
>
> Incidentally, how are you managing to get NOMATCH and NOEXEC set at
> the same time?  NOMATCH is not a default option and NOEXEC should be
> preventing any setopt calls from changing that.
>

I don't know what you are talking about.

BTW.  The 'emulate sh' is irrelevant, I added it for debugging purposes and
forgot to remove it.

Cheers.
-- 
Felipe Contreras

Re: Bug in syntax check

[Mikael Magnusson]

On Sat, Jun 4, 2016 at 8:50 AM, Bart Schaefer <schaefer@brasslantern.com> wrote:
> On Jun 4,  5:13am, Felipe Contreras wrote:
> }
> } It's better to not check anything that throw bad errors.
>
> Incidentally, how are you managing to get NOMATCH and NOEXEC set at
> the same time?  NOMATCH is not a default option and NOEXEC should be
> preventing any setopt calls from changing that.

% zsh -fc 'echo $options[nomatch]'
on

-- 
Mikael Magnusson

Re: Bug in syntax check

[Bart Schaefer]

On Jun 4,  8:38am, Felipe Contreras wrote:
}
} I don't know what you are talking about.

Sorry, the actual question should be how I managed to get it turned off.
I blame jet lag (the same reason I was awake (though plainly not all that
alert) and fiddling with this at such a strange hour).