From: Mikael Magnusson <mikachu@gmail.com>
To: Bart Schaefer <schaefer@brasslantern.com>
Cc: zsh-workers@zsh.org
Subject: Re: [PATCH] Support the mksh's ${|func;} substitution
Date: Thu, 6 Jul 2023 04:27:58 +0200 [thread overview]
Message-ID: <CAHYJk3Sn3-DUY4wPiOjayHTtByCEG=Md6D-bTZyr8ir6V8Zx-g@mail.gmail.com> (raw)
In-Reply-To: <CAH+w=7bDio8qL6DmyuOaiEo6Ybt68F1Ms5+AG_3Z_n1pM+2pKQ@mail.gmail.com>
On 7/6/23, Bart Schaefer <schaefer@brasslantern.com> wrote:
> On Tue, Jul 4, 2023 at 10:32 PM Bart Schaefer <schaefer@brasslantern.com>
> wrote:
>>
>> The first three of those are implementable within the structure of the
>> patch from workers/51898 although it's a little messy because of the
>> multiple "return" points in paramsubst().
>
> Fiddling with this has led me to find a few other issues with either
> of Sebastian's or my earlier patch in this thread, namely, both need
> to be more clever about finding the closing brace of the ${|...}
> substitution. This in turn leads me to ask if one of the old hands
> with the lexer can explain why, inside double quotes, "}" is always
> replaced by Outbrace but "{" is not replaced by Inbrace unless it is
> preceded by "$"?
>
> A small tweak to the lexer still passes all tests and makes
> skipparens(Inbrace, Outbrace, &str) work more consistently, but I
> don't want to have missed something.
I'm not one of said old hands, but presumably it's because { on its
own is not special inside double quotes? Possibly related,
% echo ${:-a{}b}
a{}b
% echo "${:-a{}b}"
a{b}
^ People occasionally get confused by this in #zsh, it comes up in
relation to %F{} or so usually.
It would probably be bad if this behavior changed.
--
Mikael Magnusson
next prev parent reply other threads:[~2023-07-06 2:28 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-03 14:46 Sebastian Gniazdowski
2023-07-04 1:55 ` Bart Schaefer
2023-07-04 18:53 ` Lawrence Velázquez
2023-07-05 5:32 ` Bart Schaefer
2023-07-05 6:30 ` Bart Schaefer
2023-07-06 1:39 ` Bart Schaefer
2023-07-06 2:27 ` Mikael Magnusson [this message]
2023-07-06 4:00 ` Bart Schaefer
2023-07-18 3:14 ` Bart Schaefer
-- strict thread matches above, loose matches on Subject: below --
2019-09-06 0:52 Sebastian Gniazdowski
2019-09-06 0:54 ` Sebastian Gniazdowski
2019-09-06 23:16 ` Sebastian Gniazdowski
2019-09-07 12:16 ` Daniel Shahaf
2019-09-07 15:07 ` Stephane Chazelas
2019-09-07 18:09 ` Sebastian Gniazdowski
2019-09-07 20:19 ` Stephane Chazelas
2019-09-07 21:19 ` Sebastian Gniazdowski
2019-09-10 2:20 ` Sebastian Gniazdowski
2019-09-10 5:29 ` Bart Schaefer
2019-09-10 18:21 ` Sebastian Gniazdowski
2019-09-10 19:38 ` Bart Schaefer
2019-09-12 0:08 ` Sebastian Gniazdowski
2019-09-12 1:03 ` Bart Schaefer
2019-09-12 2:06 ` Sebastian Gniazdowski
2019-09-12 5:35 ` Bart Schaefer
2019-09-12 6:00 ` Sebastian Gniazdowski
2019-09-12 6:55 ` Bart Schaefer
2019-09-13 20:28 ` Sebastian Gniazdowski
2019-09-13 21:33 ` Bart Schaefer
2019-09-13 21:36 ` Bart Schaefer
2019-09-14 0:41 ` Sebastian Gniazdowski
2019-09-14 0:44 ` Sebastian Gniazdowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAHYJk3Sn3-DUY4wPiOjayHTtByCEG=Md6D-bTZyr8ir6V8Zx-g@mail.gmail.com' \
--to=mikachu@gmail.com \
--cc=schaefer@brasslantern.com \
--cc=zsh-workers@zsh.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.vuxu.org/mirror/zsh/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).