* Space after if/while/for
@ 2015-09-01 21:30 Mikael Magnusson
2015-09-01 22:19 ` Bart Schaefer
0 siblings, 1 reply; 3+ messages in thread
From: Mikael Magnusson @ 2015-09-01 21:30 UTC (permalink / raw)
To: zsh workers
% git grep '\<\(if\|for\|while\)(' master -- Src/**/*.c|wc -l
656
% git grep '\<\(if\|for\|while\) (' master -- Src/**/*.c|wc -l
16021
So space after is in the clear majority. Would anyone mind if I push a
commit that adds the spaces (made with sed -i)?
--
Mikael Magnusson
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: Space after if/while/for
2015-09-01 21:30 Space after if/while/for Mikael Magnusson
@ 2015-09-01 22:19 ` Bart Schaefer
2015-09-01 22:20 ` Richo Healey
0 siblings, 1 reply; 3+ messages in thread
From: Bart Schaefer @ 2015-09-01 22:19 UTC (permalink / raw)
To: Mikael Magnusson, zsh workers
On Sep 1, 11:30pm, Mikael Magnusson wrote:
}
} Would anyone mind if I push a commit that adds the spaces (made with sed -i)?
I really prefer to avoid commits that make no semantic changes. It's much
more difficult to see when an actual meaningful change happened (e.g. with
"git blame") when there are coding-style-only changes layered on top.
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: Space after if/while/for
2015-09-01 22:19 ` Bart Schaefer
@ 2015-09-01 22:20 ` Richo Healey
0 siblings, 0 replies; 3+ messages in thread
From: Richo Healey @ 2015-09-01 22:20 UTC (permalink / raw)
To: Bart Schaefer; +Cc: zsh workers
On 01/09/15 15:19 -0700, Bart Schaefer wrote:
>On Sep 1, 11:30pm, Mikael Magnusson wrote:
>}
>} Would anyone mind if I push a commit that adds the spaces (made with sed -i)?
>
>I really prefer to avoid commits that make no semantic changes. It's much
>more difficult to see when an actual meaningful change happened (e.g. with
>"git blame") when there are coding-style-only changes layered on top.
Not taking a stance on this commit, but `git blame -w` ignores whitespace
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2015-09-01 22:27 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-09-01 21:30 Space after if/while/for Mikael Magnusson
2015-09-01 22:19 ` Bart Schaefer
2015-09-01 22:20 ` Richo Healey
Code repositories for project(s) associated with this public inbox
https://git.vuxu.org/mirror/zsh/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).