From: Felipe Contreras <felipe.contreras@gmail.com>
To: Bart Schaefer <schaefer@brasslantern.com>
Cc: Zsh hackers list <zsh-workers@zsh.org>
Subject: Re: One possible answer to typeset vs. unset
Date: Tue, 1 Dec 2020 02:54:59 -0600 [thread overview]
Message-ID: <CAMP44s2gZnM_JAi78gJwB+uX75Sdx0MQPkW7SZ6tUk85xEjvQg@mail.gmail.com> (raw)
In-Reply-To: <CAH+w=7Zh8URUiLF2n1x-ZrvKO+=JC8wf+n692sRsFTRbkJrzXw@mail.gmail.com>
On Sat, Nov 28, 2020 at 1:49 PM Bart Schaefer <schaefer@brasslantern.com> wrote:
> You can see these changes by checking out the "declarednull" branch.
I tried this branch, and I tried to make it pass all the tests. And it
did mostly work, except with tied variables.
I don't know what would be the proper solution for tied variables, but
I used this hack to make the tests pass:
--- a/Src/builtin.c
+++ b/Src/builtin.c
@@ -2513,6 +2513,7 @@ typeset_single(char *cname, char *pname, Param
pm, UNUSED(int func),
}
tdp->joinchar = joinchar;
tdp->arrptr = &altpm->u.arr;
+ altpm->node.flags &= ~PM_DECLAREDNULL;
pm->gsu.s = &tiedarr_gsu;
pm->u.data = tdp;
--
Felipe Contreras
next prev parent reply other threads:[~2020-12-01 8:55 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-28 19:49 Bart Schaefer
2020-11-28 20:00 ` Bart Schaefer
2020-11-28 20:21 ` Bart Schaefer
2020-12-01 8:54 ` Felipe Contreras [this message]
2020-12-03 21:19 ` Bart Schaefer
2020-12-04 11:04 ` Felipe Contreras
2020-12-04 15:49 ` Bart Schaefer
2020-12-04 19:47 ` Bart Schaefer
2020-12-05 0:22 ` Bart Schaefer
2020-12-05 0:28 ` Bart Schaefer
2020-12-05 0:51 ` Bart Schaefer
2020-12-05 22:17 ` Bart Schaefer
2020-12-23 23:00 ` Felipe Contreras
2020-12-02 17:18 ` Vincent Lefevre
2020-12-02 18:03 ` Bart Schaefer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAMP44s2gZnM_JAi78gJwB+uX75Sdx0MQPkW7SZ6tUk85xEjvQg@mail.gmail.com \
--to=felipe.contreras@gmail.com \
--cc=schaefer@brasslantern.com \
--cc=zsh-workers@zsh.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.vuxu.org/mirror/zsh/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).