Minor bugs in _unsetopt and _main_complete ?

Minor bugs in _unsetopt and _main_complete ?

[香川 亘]

While trying to configure the setopt and unsetopt commands to complete 
only unset and set options, respectively, I think I found some bugs in 
the _unsetopt and _main_complete functions.

In _unsetopt, "_options_set || _options" should be,

_options_unset || _options

and in _main_complete,

_options_set=(${(k)options[(R)on]})
_options_unset=(${(k)options[(R)off]})

should be,

_options_set=(${(k)options[(R)off]})
_options_unset=(${(k)options[(R)on]})

I am wondering if the CVS versions should include this fix.


Wataru Kagawa, Ph. D.
Postdoctoral Researcher
Protein Research Group
RIKEN (Physical and Chemical Research Institute)

W221, West Research Bldg.
1-7-22 Suehiro-cho, Tsurumi-ku
Yokohama, Japan 230-0045

tel.	045-503-9206
fax.	045-503-9201

Re: Minor bugs in _unsetopt and _main_complete ?

[Wayne Davison]

[I had thought that someone else would respond to this message, but
since no one did, let me give you a late reply.]

On Fri, Dec 10, 2004 at 11:25:53AM +0900, ?$B9a@n ?$BOK wrote:
> In _unsetopt, "_options_set || _options" should be,
> 
> _options_unset || _options
> 
> and in _main_complete,
> 
> _options_set=(${(k)options[(R)on]})
> _options_unset=(${(k)options[(R)off]})
> 
> should be,
> 
> _options_set=(${(k)options[(R)off]})
> _options_unset=(${(k)options[(R)on]})

You seem to be thinking about the variables in the opposite manner in
which they were intended.  The _options_set variable contains set
options (not options that can be set), so it is used to complete
unsettable options in _unsetopt.  I think this interpretation of the
options is evident in this comment in _main_complete:

    # If you want to complete only set or unset options for the unsetopt
    # and setopt builtin, un-comment these lines:

This is followed by _options_set (the set options) and _options_unset
(the unset options).  Certainly, your choice to reverse the meaning in
both the setting and use of these variables will work fine for your
configuration, but I think the CVS version should remain unchanged.

..wayne..

Re: Minor bugs in _unsetopt and _main_complete ?

[Wataru Kagawa]

Thanks for the reply.  I was incorrect.  I was actually trying to use 
_options_set and _options_unsetopt the way they were intended, but got 
confused after playing with the original functions.

Please excuse my ignorance.