zsh-workers
 help / color / Atom feed
From: dana <dana@dana.is>
To: Andrey <butirsky@gmail.com>
Cc: Daniel Shahaf <d.s@daniel.shahaf.name>,
	Zsh hackers list <zsh-workers@zsh.org>
Subject: Re: sudo autocompletion
Date: Mon, 10 Feb 2020 11:13:52 -0600
Message-ID: <D0BDD1BB-192E-4D50-A0D2-0BB54388B9B9@dana.is> (raw)
In-Reply-To: <ADE72275-1311-44BE-9B1D-5E617E3D9F94@gmail.com>

On 10 Feb 2020, at 01:52, Andrey <butirsky@gmail.com> wrote:
> Thanks, will try it. How about to include it in distribution by default?

Would this be too cheeky?

There's not much precedent for this sort of thing (just cache-policy), but i
don't think it'd cause any issues, aside from showing too many commands in
some uncommon cases...?

(Moved to -workers)

dana


diff --git a/Completion/Unix/Command/_sudo b/Completion/Unix/Command/_sudo
index 41e32cbae..52b212176 100644
--- a/Completion/Unix/Command/_sudo
+++ b/Completion/Unix/Command/_sudo
@@ -54,6 +54,18 @@ else
     '(-)1:command: _command_names -e'
     '*::arguments:{ _comp_priv_prefix=( $cmd -n ${(kv)opt_args[(I)(-[ugHEP]|--(user|group|set-home|preserve-env|preserve-groups))]} ) ; _normal }'
   )
+
+  # By default, _command_names uses the current PATH to complete commands. This
+  # doesn't necessarily make sense for sudo on systems that use its secure_path
+  # feature -- a common issue is that /**/sbin appear in secure_path but not in
+  # unprivileged users' PATHs. Ideally we could parse the correct value out of
+  # `sudo -l`, but since that requires a password it won't work half the time.
+  # To do the right thing in the most common cases, we'll simply ensure that the
+  # sbin variants always appear in the default command-path (bash-completion's
+  # _sudo does something similar)
+  zstyle -t ":completion:${curcontext}:" command-path ||
+  zstyle -e ":completion:${curcontext%:}:*" command-path \
+    'reply=( $path ${path/%\/bin//sbin} )'
 fi
 
 _arguments -s -S $args


       reply index

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <912d22db-8a8f-90f2-6738-f9f395994dcb@gmail.com>
     [not found] ` <CAN=4vMqvzUTZ7bBLcbTzi-pKAVEP1xDbq=f5pLAxmffxUjTszQ@mail.gmail.com>
     [not found]   ` <1770be62-54d8-70a6-8b05-cfc98faa9b9f@gmail.com>
     [not found]     ` <20200210030219.527a3ccf@tarpaulin.shahaf.local2>
     [not found]       ` <ADE72275-1311-44BE-9B1D-5E617E3D9F94@gmail.com>
2020-02-10 17:13         ` dana [this message]
2020-02-10 17:40           ` Peter Stephenson
2020-02-10 18:57             ` dana
2020-02-10 19:20           ` Daniel Shahaf
2020-02-11 10:12             ` Oliver Kiddle
2020-02-11 10:28               ` Setting/Querying cache-policy (was: Re: sudo autocompletion) Daniel Shahaf
2020-02-12 16:51                 ` dana
2020-02-13  1:21               ` sudo autocompletion dana
2020-02-13  1:29                 ` Bart Schaefer
2020-02-15 22:22                 ` Andrey Butirsky
2020-02-15 22:48                   ` dana
2020-02-10 22:05           ` Andrey Butirsky
2020-02-10 23:02             ` dana

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=D0BDD1BB-192E-4D50-A0D2-0BB54388B9B9@dana.is \
    --to=dana@dana.is \
    --cc=butirsky@gmail.com \
    --cc=d.s@daniel.shahaf.name \
    --cc=zsh-workers@zsh.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

zsh-workers

Archives are clonable: git clone --mirror http://inbox.vuxu.org/zsh-workers

Example config snippet for mirrors

Newsgroup available over NNTP:
	nntp://inbox.vuxu.org/vuxu.archive.zsh.workers


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git