From: Matthew Martin <email@example.com>
Subject: Re: Hang in E01 due to zpty on OpenBSD
Date: Wed, 6 Apr 2022 23:52:08 -0500 [thread overview]
Message-ID: <Yk5t+G89hj59E2LH@CptOrmolo.darkstar> (raw)
On Thu, Apr 07, 2022 at 12:47:18PM +0900, Jun T wrote:
> > 2022/04/06 21:53, Matthew Martin <firstname.lastname@example.org> wrote:
> > I'd prefer something like the below where it's a feature test instead of
> > an OS test.
> I was thinking that we should better minimize the possible side effects
> just before the new release.
> If we use your patch (with some fixes) openpty() will be used on ALL systems
> (Linux, other BSDs and macOS, ...) if it is available. Is this what you
> want to achieve? It may work but we need to test on lots of systems.
I was thinking I'd wait until after the release and put the patch in the
OpenBSD port until the next release. That way things are fixed with no
need to rush.
> > diff --git a/Src/Modules/zpty.c b/Src/Modules/zpty.c
> > +#elifdef USE_DEV_PTMX
> #elif defined(USE_DEV_PTMX)
> > -#elif defined(__OpenBSD__)
> > - static char char1 = "pqrstuvwxyzPQRST";
> > - static char char2 = "0123456789"
> > - "abcdefghijklmnopqrstuvwxyz"
> > - "ABCDEFGHIJKLMNOPQRSTUVWXYZ";
They no longer really support the /dev/ptyxx route. When I asked the
response I got was, why do you think that should work it's dead and
archaic. If openpty is removed in the future, falling back to /dev/pty
is unlikely to be an option.
> > diff --git a/configure.ac b/configure.ac
> > +AC_MSG_CHECKING([for openpty])
> > +openpty=no
> We need to call AC_SEARCH_LIBS(openpty, util) here to add -lutil to LIBS.
> Otherwise the following two AC_LINK_IFELSE() fail and openpty() will never
> be used.
It worked here, but I don't claim to be an auto* expert. So just put the
AC_SEARCH_LIBS before AC_MSG_CHECKING (otherwise the output is mixed up)?
next prev parent reply other threads:[~2022-04-07 4:52 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-03 21:42 Matthew Martin
2022-04-04 1:04 ` Bart Schaefer
2022-04-04 2:34 ` Matthew Martin
2022-04-04 3:49 ` Matthew Martin
2022-04-04 8:34 ` Jun T
2022-04-04 11:21 ` Mikael Magnusson
2022-04-04 13:16 ` Matthew Martin
2022-04-06 5:48 ` Jun T
2022-04-06 12:53 ` Matthew Martin
2022-04-06 20:12 ` Bart Schaefer
2022-04-07 3:47 ` Jun T
2022-04-07 4:52 ` Matthew Martin [this message]
2022-04-08 7:51 ` Jun T
2022-04-04 2:39 ` Jun T
2022-04-04 2:51 ` Matthew Martin
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).