* PATCH: silence compiler
@ 2009-11-06 21:18 Peter Stephenson
2009-11-07 19:42 ` Stephane Chazelas
0 siblings, 1 reply; 2+ messages in thread
From: Peter Stephenson @ 2009-11-06 21:18 UTC (permalink / raw)
To: Zsh hackers list
Index: Src/Modules/attr.c
===================================================================
RCS file: /cvsroot/zsh/zsh/Src/Modules/attr.c,v
retrieving revision 1.5
diff -u -r1.5 attr.c
--- Src/Modules/attr.c 5 Nov 2009 09:44:32 -0000 1.5
+++ Src/Modules/attr.c 6 Nov 2009 21:18:29 -0000
@@ -42,7 +42,7 @@
switch (symlink) {
case 0:
return getxattr(path, name, value, size);
- case 1:
+ default:
return lgetxattr(path, name, value, size);
}
#endif
@@ -57,7 +57,7 @@
switch (symlink) {
case 0:
return listxattr(path, list, size);
- case 1:
+ default:
return llistxattr(path, list, size);
}
#endif
@@ -73,7 +73,7 @@
switch (symlink) {
case 0:
return setxattr(path, name, value, size, flags);
- case 1:
+ default:
return lsetxattr(path, name, value, size, flags);
}
#endif
@@ -88,7 +88,7 @@
switch (symlink) {
case 0:
return removexattr(path, name);
- case 1:
+ default:
return lremovexattr(path, name);
}
#endif
--
Peter Stephenson <p.w.stephenson@ntlworld.com>
Web page now at http://homepage.ntlworld.com/p.w.stephenson/
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: PATCH: silence compiler
2009-11-06 21:18 PATCH: silence compiler Peter Stephenson
@ 2009-11-07 19:42 ` Stephane Chazelas
0 siblings, 0 replies; 2+ messages in thread
From: Stephane Chazelas @ 2009-11-07 19:42 UTC (permalink / raw)
To: Peter Stephenson; +Cc: Zsh hackers list
2009-11-06 21:18:58 +0000, Peter Stephenson:
> Index: Src/Modules/attr.c
> ===================================================================
> RCS file: /cvsroot/zsh/zsh/Src/Modules/attr.c,v
> retrieving revision 1.5
> diff -u -r1.5 attr.c
> --- Src/Modules/attr.c 5 Nov 2009 09:44:32 -0000 1.5
> +++ Src/Modules/attr.c 6 Nov 2009 21:18:29 -0000
> @@ -42,7 +42,7 @@
> switch (symlink) {
> case 0:
> return getxattr(path, name, value, size);
> - case 1:
> + default:
> return lgetxattr(path, name, value, size);
> }
[...]
I don't know the context but why not if/else? or return (symlink
? lgetxattr... : getxattr... )?
Cheers,
Stephane
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2009-11-07 19:49 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2009-11-06 21:18 PATCH: silence compiler Peter Stephenson
2009-11-07 19:42 ` Stephane Chazelas
Code repositories for project(s) associated with this public inbox
https://git.vuxu.org/mirror/zsh/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).