From: dana <dana@dana.is>
To: "Bart Schaefer" <schaefer@brasslantern.com>,
"Zsh hackers list" <zsh-workers@zsh.org>
Cc: "Marlon Richert" <marlon.richert@gmail.com>
Subject: Re: [PATCH][RFC] Improve completion of Gradle tasks
Date: Fri, 06 May 2022 23:24:25 -0500 [thread overview]
Message-ID: <e288b6d0-c76e-482d-92e2-630b971ff49b@www.fastmail.com> (raw)
In-Reply-To: <CAH+w=7bLoALZV=eX3DKNEyMGhwdmC=Wf9o0n5r=B5VH9kuyJ2A@mail.gmail.com>
On Fri 6 May 2022, at 21:57, Bart Schaefer wrote:
> Any objections to this sneaking into 5.9, despite .3-test already spun?
I don't know anything about Gradle, so i'm not sure if the way it handles
task completion is desirable. But i didn't see anything obviously wrong
with the patch, and it's not a critical component, so i don't object in
principle
I did note these pre-existing issues which might be fixed in a future
revision:
* _gradle_caching_policy is redefined every time the function executes
* possibly _arguments should have -s and/or -S?
* several of the options seem to be missing exclusion information
* none of the option descriptions use the conventional capitalisation,
punctuation, or mood for completion functions
* there seems to be some confusion over whether short options that take
arguments need + in the spec, and possibly the long options need =
* completion for -x just fails silently if there's no build file
dana
next prev parent reply other threads:[~2022-05-07 4:25 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-01 6:19 Marlon Richert
2022-05-06 5:51 ` Marlon Richert
2022-05-07 2:57 ` Bart Schaefer
2022-05-07 4:24 ` dana [this message]
2022-05-07 6:03 ` Marlon Richert
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e288b6d0-c76e-482d-92e2-630b971ff49b@www.fastmail.com \
--to=dana@dana.is \
--cc=marlon.richert@gmail.com \
--cc=schaefer@brasslantern.com \
--cc=zsh-workers@zsh.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.vuxu.org/mirror/zsh/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).