From: Rich Felker <dalias@libc.org>
To: Alexander Weps <exander77@pm.me>
Cc: musl@lists.openwall.com
Subject: Re: [musl] Broken mktime calculations when crossing DST boundary
Date: Mon, 25 Mar 2024 15:47:25 -0400 [thread overview]
Message-ID: <20240325194725.GI4163@brightrain.aerifal.cx> (raw)
In-Reply-To: <20240325193813.GH4163@brightrain.aerifal.cx>
On Mon, Mar 25, 2024 at 03:38:13PM -0400, Rich Felker wrote:
> On Mon, Mar 25, 2024 at 06:57:49PM +0000, Alexander Weps wrote:
> > I am not sure which one you mean, all latest codes even includes
> > headers and main...
>
> https://www.openwall.com/lists/musl/2024/03/25/3
>
> > I have no idea what to tell you.
>
> The first version I found that's actually compilable is:
>
> https://www.openwall.com/lists/musl/2024/03/25/11
>
> It roughly behaves as expected on musl, except possibly not applying
> the tm_isdst=0, which is what was making the output confusing on
> glibc -- that threw the input back across the rule change cutoff.
No, it's deeper than this. glibc is offsetting the input by an entire
day when tm_isdst=0, and I don't know why. It looks like a bug in
glibc.
> With tm_isdst=1 and tm_mday=31, on glibc, I get:
>
> before: 2011-12-31 00:00:00 WSDT 0
> after1: 2011-12-31 00:00:00 WSDT 1325239200
> after2: 2011-12-30 00:00:00 WSDT -1
> after3: 2011-12-31 00:00:00 WSDT 1325239200
>
> The -1 in the after2 line indicates that mktime failed with an error
> (and should not have modified tm; that's arguably a bug in glibc). The
> partial modification that it made reflects the initial normalization
> (type 1 in my notation) but not the rule change normalization (type 2
> in my notation) since glibc has failed the operation for an input date
> that does not exist on the calendar (it does not do type 2
> normalization at all; it just rejects it).
>
> Running this same change on musl, I get:
>
> before: 2011-12-31 00:00:00 0
> after1: 2011-12-31 00:00:00 +14 1325239200
> after2: 2011-12-29 00:00:00 -10 1325152800
> after3: 2011-12-29 00:00:00 -10 1325152800
>
> which again is what I expect. From one side, the move-by-1-day changes
> the time to the next calendar day in that direction. From the other
> side, it's unable to change it.
>
> I'll look into why the tm_isdst=0 application was not happening.
Hmm, I must have misread the output. It seems to be correct with
tm_isdst=0 too:
before: 2011-12-31 00:00:00 0
after1: 2011-12-31 01:00:00 +14 1325242800
after2: 2011-12-29 01:00:00 -10 1325156400
after3: 2011-12-29 01:00:00 -10 1325156400
(If it's 00:00:00 in standard time, it's 01:00:00 in DST, so the
initial time seems to have been interpreted correctly.)
I also went back and tested both with tm_isdst=-1, and both glibc and
musl do the same thing as they do with tm_isdst=1 (which is correct).
Rich
next prev parent reply other threads:[~2024-03-25 19:47 UTC|newest]
Thread overview: 76+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-24 13:36 Alexander Weps
2024-03-24 16:59 ` Alexander Weps
2024-03-24 17:04 ` Rich Felker
2024-03-24 17:12 ` Alexander Weps
2024-03-24 18:00 ` Alexander Weps
2024-03-24 18:02 ` Rich Felker
2024-03-24 18:16 ` Alexander Weps
2024-03-24 18:24 ` Rich Felker
2024-03-24 18:36 ` Alexander Weps
2024-03-24 19:01 ` Joakim Sindholt
2024-03-24 19:05 ` Alexander Weps
2024-03-24 19:06 ` Alexander Weps
2024-03-24 19:13 ` Alexander Weps
2024-03-24 19:13 ` Alexander Weps
2024-03-24 19:22 ` Rich Felker
2024-03-24 19:57 ` Alexander Weps
2024-03-24 20:22 ` Rich Felker
2024-03-24 20:50 ` Alexander Weps
2024-03-24 21:43 ` Alexander Weps
2024-03-24 23:51 ` Thorsten Glaser
2024-03-25 0:36 ` Alexander Weps
2024-03-25 11:52 ` Alexander Weps
2024-03-25 12:21 ` Rich Felker
2024-03-25 12:55 ` Alexander Weps
2024-03-25 13:08 ` Rich Felker
2024-03-25 13:13 ` Alexander Weps
2024-03-25 13:13 ` Rich Felker
2024-03-25 13:24 ` Alexander Weps
2024-03-25 13:42 ` Rich Felker
2024-03-25 13:48 ` Alexander Weps
2024-03-25 13:50 ` Alexander Weps
2024-03-25 18:02 ` Rich Felker
2024-03-25 18:28 ` Alexander Weps
2024-03-25 18:53 ` Rich Felker
2024-03-25 18:57 ` Alexander Weps
2024-03-25 19:38 ` Rich Felker
2024-03-25 19:47 ` Rich Felker [this message]
2024-03-25 20:05 ` Alexander Weps
2024-03-25 20:12 ` Alexander Weps
2024-03-25 20:00 ` Alexander Weps
2024-03-25 20:23 ` Rich Felker
2024-03-25 20:31 ` Rich Felker
2024-03-25 23:19 ` Thorsten Glaser
2024-03-25 23:16 ` Thorsten Glaser
2024-03-25 13:44 ` Alexander Weps
2024-03-25 22:40 ` Thorsten Glaser
2024-03-25 22:59 ` Alexander Weps
2024-03-25 23:34 ` Thorsten Glaser
2024-03-26 12:45 ` Alexander Weps
2024-03-26 21:59 ` Thorsten Glaser
2024-03-27 0:14 ` Alexander Weps
2024-03-27 0:38 ` Alexander Weps
2024-03-27 1:35 ` Thorsten Glaser
2024-03-27 2:45 ` Alexander Weps
2024-03-27 4:42 ` Thorsten Glaser
2024-03-26 18:56 ` Alexander Weps
2024-03-25 23:13 ` Rich Felker
-- strict thread matches above, loose matches on Subject: below --
2024-03-22 19:56 Alexander Weps
2024-03-23 6:41 ` Markus Wichmann
[not found] ` <528SeRFaPfDw7fA4kqKDlio1U4RB_t9nmUemPcWw9_t1e2hBDpXYFmOqxAC37szgYvAVtmTuXWsmT64SSN3cSQFVdrQqXUAgkdTMPZQ0bg0=@pm.me>
2024-03-23 10:38 ` Markus Wichmann
2024-03-23 11:59 ` Alexander Weps
2024-03-23 12:00 ` Alexander Weps
2024-03-23 12:31 ` Rich Felker
2024-03-23 13:49 ` Alexander Weps
2024-03-23 15:31 ` Rich Felker
2024-03-23 16:54 ` Alexander Weps
2024-03-23 18:57 ` Alexander Weps
2024-03-23 19:33 ` Alexander Weps
2024-03-23 20:18 ` Rich Felker
2024-03-23 20:40 ` Alexander Weps
2024-03-24 0:36 ` Eric Pruitt
2024-03-24 2:04 ` Rich Felker
2024-03-24 3:32 ` Daniel Gutson
2024-03-24 11:05 ` Alexander Weps
2024-03-24 13:24 ` Alexander Weps
2024-03-23 12:01 ` Alexander Weps
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240325194725.GI4163@brightrain.aerifal.cx \
--to=dalias@libc.org \
--cc=exander77@pm.me \
--cc=musl@lists.openwall.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.vuxu.org/mirror/musl/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).