From: Alexander Weps <exander77@pm.me>
To: "musl@lists.openwall.com" <musl@lists.openwall.com>
Subject: [musl] Broken mktime calculations when crossing DST boundary
Date: Fri, 22 Mar 2024 19:56:47 +0000 [thread overview]
Message-ID: <IGOThaBbQ5xnPGl1MXBDvGHznS3Ca6DQxxYzxIfBi2ixgXUGJradw6NwoqExVkjVdTf-y_MmdlB09u4OPlDFqtGl1YP2RSK1cuH9LdXM7LM=@pm.me> (raw)
[-- Attachment #1: Type: text/plain, Size: 763 bytes --]
Consider this struct tm for in CET (Europe/Prague):
tm_sec: 3
tm_min: 59
tm_hour: 1
tm_mday: 31
tm_mon: 2
tm_year: 124
tm_wday: 0
tm_yday: 90
tm_isdst: 0
Representing:
2024-03-31 01:59:02
Add a minute and call mktime (crossing DST boundary).
Instead of getting:
2024-03-31 03:00:02
You get:
2024-03-31 01:00:02
tm_sec: 3
tm_min: 0
tm_hour: 1
tm_mday: 31
tm_mon: 2
tm_year: 124
tm_wday: 0
tm_yday: 90tm_isdst: 0
Not only We are going backwards, DST flag is not even set.
Glibc behaves correctly:
tm_sec: 3
tm_min: 0
tm_hour: 3
tm_mday: 31
tm_mon: 2
tm_year: 124
tm_wday: 0
tm_yday: 90tm_isdst: 1
tm_hour = 3 and tm_isdst = 1
This pretty messes with my cron tool that rely on mktime being able to correctly calculate struct tm after incrementing fields.
AW
[-- Attachment #2: Type: text/html, Size: 2905 bytes --]
next reply other threads:[~2024-03-22 19:57 UTC|newest]
Thread overview: 76+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-22 19:56 Alexander Weps [this message]
2024-03-23 6:41 ` Markus Wichmann
[not found] ` <528SeRFaPfDw7fA4kqKDlio1U4RB_t9nmUemPcWw9_t1e2hBDpXYFmOqxAC37szgYvAVtmTuXWsmT64SSN3cSQFVdrQqXUAgkdTMPZQ0bg0=@pm.me>
2024-03-23 10:38 ` Markus Wichmann
2024-03-23 11:59 ` Alexander Weps
2024-03-23 12:00 ` Alexander Weps
2024-03-23 12:31 ` Rich Felker
2024-03-23 13:49 ` Alexander Weps
2024-03-23 15:31 ` Rich Felker
2024-03-23 16:54 ` Alexander Weps
2024-03-23 18:57 ` Alexander Weps
2024-03-23 19:33 ` Alexander Weps
2024-03-23 20:18 ` Rich Felker
2024-03-23 20:40 ` Alexander Weps
2024-03-24 0:36 ` Eric Pruitt
2024-03-24 2:04 ` Rich Felker
2024-03-24 3:32 ` Daniel Gutson
2024-03-24 11:05 ` Alexander Weps
2024-03-24 13:24 ` Alexander Weps
2024-03-23 12:01 ` Alexander Weps
2024-03-24 13:36 Alexander Weps
2024-03-24 16:59 ` Alexander Weps
2024-03-24 17:04 ` Rich Felker
2024-03-24 17:12 ` Alexander Weps
2024-03-24 18:00 ` Alexander Weps
2024-03-24 18:02 ` Rich Felker
2024-03-24 18:16 ` Alexander Weps
2024-03-24 18:24 ` Rich Felker
2024-03-24 18:36 ` Alexander Weps
2024-03-24 19:01 ` Joakim Sindholt
2024-03-24 19:05 ` Alexander Weps
2024-03-24 19:06 ` Alexander Weps
2024-03-24 19:13 ` Alexander Weps
2024-03-24 19:13 ` Alexander Weps
2024-03-24 19:22 ` Rich Felker
2024-03-24 19:57 ` Alexander Weps
2024-03-24 20:22 ` Rich Felker
2024-03-24 20:50 ` Alexander Weps
2024-03-24 21:43 ` Alexander Weps
2024-03-24 23:51 ` Thorsten Glaser
2024-03-25 0:36 ` Alexander Weps
2024-03-25 11:52 ` Alexander Weps
2024-03-25 12:21 ` Rich Felker
2024-03-25 12:55 ` Alexander Weps
2024-03-25 13:08 ` Rich Felker
2024-03-25 13:13 ` Alexander Weps
2024-03-25 13:13 ` Rich Felker
2024-03-25 13:24 ` Alexander Weps
2024-03-25 13:42 ` Rich Felker
2024-03-25 13:48 ` Alexander Weps
2024-03-25 13:50 ` Alexander Weps
2024-03-25 18:02 ` Rich Felker
2024-03-25 18:28 ` Alexander Weps
2024-03-25 18:53 ` Rich Felker
2024-03-25 18:57 ` Alexander Weps
2024-03-25 19:38 ` Rich Felker
2024-03-25 19:47 ` Rich Felker
2024-03-25 20:05 ` Alexander Weps
2024-03-25 20:12 ` Alexander Weps
2024-03-25 20:00 ` Alexander Weps
2024-03-25 20:23 ` Rich Felker
2024-03-25 20:31 ` Rich Felker
2024-03-25 23:19 ` Thorsten Glaser
2024-03-25 23:16 ` Thorsten Glaser
2024-03-25 13:44 ` Alexander Weps
2024-03-25 22:40 ` Thorsten Glaser
2024-03-25 22:59 ` Alexander Weps
2024-03-25 23:34 ` Thorsten Glaser
2024-03-26 12:45 ` Alexander Weps
2024-03-26 21:59 ` Thorsten Glaser
2024-03-27 0:14 ` Alexander Weps
2024-03-27 0:38 ` Alexander Weps
2024-03-27 1:35 ` Thorsten Glaser
2024-03-27 2:45 ` Alexander Weps
2024-03-27 4:42 ` Thorsten Glaser
2024-03-26 18:56 ` Alexander Weps
2024-03-25 23:13 ` Rich Felker
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='IGOThaBbQ5xnPGl1MXBDvGHznS3Ca6DQxxYzxIfBi2ixgXUGJradw6NwoqExVkjVdTf-y_MmdlB09u4OPlDFqtGl1YP2RSK1cuH9LdXM7LM=@pm.me' \
--to=exander77@pm.me \
--cc=musl@lists.openwall.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.vuxu.org/mirror/musl/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).