9fans - fans of the OS Plan 9 from Bell Labs
 help / color / mirror / Atom feed
From: "Russ Cox" <rsc@swtch.com>
To: 9fans@cse.psu.edu
Subject: Re: [9fans] proposal: a patch acceptance system
Date: Sun,  2 Nov 2003 15:23:25 -0500	[thread overview]
Message-ID: <E1AGOkv-000Fj1-CX@t40.swtch.com> (raw)
In-Reply-To: Your message of "Sun, 02 Nov 2003 10:01:54 MST." <Pine.LNX.4.44.0311020929200.11290-100000@fbsd.cpsc.ucalgary.ca>

The main problem with the current system (email 9trouble) is that
the reading of 9trouble itself is spotty.  But if we end up with a
different patch submission system there's no reason to believe the
problem would go away.  I was reading 9trouble pretty regularly
before the summer, but then it got away from me.  Dave has been
keeping up pretty well otherwise.

When we don't like a patch, we reply and tell you.  If you're not
getting replies it means we're behind.  There's still a lot of good
stuff sitting in the 9trouble box that I just have never gotten to.
I think what you're trying to address is the not knowing whether
we're busy or we silently deleted your bad idea.  But we don't silently
delete bad ideas.  It just seems that way since we get behind sometimes.

I don't think the code drift is too big a concern.  If you include
in the files the copy you are changing, then it's no big deal to
generate the diffs and apply them to the current file.
Your solution of checking for patches every time you update
a file isn't accurate -- we make the changes in our local
tree and then eventually they make it to sources.

It sounds like more than anything else what you want is a way to
check on your submitted changes, which is entirely reasonable.

Sitting on the other side of the fence, I want an easy way to
accept patches, basically a button to push when I think it's good
that will apply the change.  And when they're not good, I want
an easy way to send people back to the drawing board with
constructive comments (like, "make the code style look like all the
other code so your patch doesn't stick out like a sore thumb",
though that hasn't happened recently).

I built a simple patch tracking system based on your proposal.
Let's see how it works.  See patch(1).

Russ


  reply	other threads:[~2003-11-02 20:23 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2003-11-02 17:01 andrey mirtchovski
2003-11-02 20:23 ` Russ Cox [this message]
2003-11-02 20:47   ` andrey mirtchovski
2003-11-03 10:16     ` Michael Giegerich
2003-11-03 15:05       ` Russ Cox
2003-11-17 10:25         ` Michael Giegerich
2003-11-03 13:56   ` kazumi iwane
2003-11-03 15:01     ` Russ Cox
2003-11-03 15:18       ` Fco.J.Ballesteros
2003-11-02 17:32 David Presotto
2003-11-02 17:45 ` a
     [not found] <e89c2b9ccc6e9a8bfbc532c129cbc4c0@plan9.bell-labs.com>
2003-11-02 17:44 ` andrey mirtchovski

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=E1AGOkv-000Fj1-CX@t40.swtch.com \
    --to=rsc@swtch.com \
    --cc=9fans@cse.psu.edu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).