9fans - fans of the OS Plan 9 from Bell Labs
 help / color / mirror / Atom feed
From: andrey mirtchovski <mirtchov@cpsc.ucalgary.ca>
To: 9fans@cse.psu.edu
Subject: [9fans] proposal: a patch acceptance system
Date: Sun,  2 Nov 2003 10:01:54 -0700	[thread overview]
Message-ID: <Pine.LNX.4.44.0311020929200.11290-100000@fbsd.cpsc.ucalgary.ca> (raw)

Hello,

Several people have discussed on IRC the need for a definitive way of
submitting patches (enhancements and fixes) to Plan 9 developers with write
privileges. Currently this happens in three different ways -- sending
patches to 9fans, sending patches (fixes mostly) to 9trouble, and via
personal communication with people who can do a push on sources.

What this mechanism lacks is an easy way to get feedback on rejected or
accepted patches, and a way for developers to discriminate good and bad
ones and to know which patches have been outstanding.

We think the following solution could be sufficiently simple and general to
accomodate our needs:

Enhancements and fixes by people lacking the ability to 'push' on sources
could be put (by the users themselves) in a world-writeable directory
"/patches" on sources.cs.bell-labs.com. A particular set of patched files
submitted by a user will be located in:

	/patches/MMDD.user/*

where MM is the month, DD is the day and 'user' is the username of the
person submitting the patch, as it appears on the sources auth server.

Along with the changed files the user must submit a short README describing
in detail what this patch accomplishes, and where those files appear
relevant to the root of a Plan 9 system tree (no need to create complex
directory structures just to put a couple of files there).

Whether an announcement is made to 9fans or not is left for the user to
decide.

Plan 9 developers can then examine /patch for outstanding patches and either
add them to the system, in which case the MMDD.user directory can disappear
(it will be available in the next pull) or reject them, in which case they
go to:

	/patches/rejected/MMDD.user/

with a small 'reason' file added, where the reason for the rejection is
given. This could be made private and viewable only by the person who
submitted the patch.

One major issue with this scheme is synchronization -- making sure the files
submitted patch the latest system is left as an exercise for the patch
submitter, and making sure there's no "push"-ing of files for which there
are patches outstanding is done by the person doing the "push" (it's just a
simple "ls /patches/*/file" before "push -c /path/to/file" is done on
sources)...

Any coments will be appreciated, as long as you have in mind that we're
trying to cut short of writing a new bugzilla :)

andrey



             reply	other threads:[~2003-11-02 17:01 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2003-11-02 17:01 andrey mirtchovski [this message]
2003-11-02 20:23 ` Russ Cox
2003-11-02 20:47   ` andrey mirtchovski
2003-11-03 10:16     ` Michael Giegerich
2003-11-03 15:05       ` Russ Cox
2003-11-17 10:25         ` Michael Giegerich
2003-11-03 13:56   ` kazumi iwane
2003-11-03 15:01     ` Russ Cox
2003-11-03 15:18       ` Fco.J.Ballesteros
2003-11-02 17:32 David Presotto
2003-11-02 17:45 ` a
     [not found] <e89c2b9ccc6e9a8bfbc532c129cbc4c0@plan9.bell-labs.com>
2003-11-02 17:44 ` andrey mirtchovski

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Pine.LNX.4.44.0311020929200.11290-100000@fbsd.cpsc.ucalgary.ca \
    --to=mirtchov@cpsc.ucalgary.ca \
    --cc=9fans@cse.psu.edu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).