* Re: Archiving Inbox
2000-08-04 15:17 ` Kai Großjohann
@ 2000-08-04 17:55 ` Harry Putnam
2000-08-10 16:39 ` Kai Großjohann
2000-08-06 23:23 ` Rod Whitby
1 sibling, 1 reply; 7+ messages in thread
From: Harry Putnam @ 2000-08-04 17:55 UTC (permalink / raw)
Kai.Grossjohann@CS.Uni-Dortmund.DE (Kai Großjohann) writes:
> On Fri, 04 Aug 2000, Harry Putnam wrote:
>
> > ((expiry-target . "nnml:target")
> > (expiry-wait . 21 ))
> >
> > ((expiry-target . "nnml:target)
> > (total-expire . t )
> > (expiry-wait . 14 ))
>
> I haven't tried this, but these settings look good. (That is, that's
> what I would have set if I wanted to try the feature.) Is there a bug
> in Gnus?
>
> Has anybody tried this?
It also wasn't clear to me from info, what role the variable
`nnmail-expiry-target' plays in all this. It can be set to a string
or function, yes but does that then apply to all expiry globally or
what?
That is, if one sets nnmail-expiry-target to "nnml:target" will all
expiry then send messages to nnml:target?
Or is that var set only in Group params.
Far as I can see, this is the sum total available in `info'
The normal action taken when expiring articles is to delete them.
However, in some circumstances it might make more sense to move them to
other groups instead of deleting them. The `nnmail-expiry-target' (and
the `expiry-target' group parameter) controls this. The default value
is `delete', but this can also be a string (which should be the name of
the group the message should be moved to), or a function (which will be
called in a buffer narrowed to the message in question, and with the
name of the group being moved from as its parameter) which should
return a target - either a group name or `delete'.
Just too ambiguous to tell what is needed. Do both
`nnmail-expiry-target' and group param `expiry-target' need to be set?
Unless there is a consensus that gnus info is only meant for elisp
progammers, then I will submit further that the section:
. . . . . . . . . . . . . . . . . . . . . . . . The default value
is `delete', but this can also be a string (which should be the name of
the group the message should be moved to), or a function (which will be
called in a buffer narrowed to the message in question, and with the
name of the group being moved from as its parameter) which should
return a target - either a group name or `delete'.
Can only make sense to someone conversant with elisp programming. And
should be written in common parlance, or a simple example of what is
meant be included. Those should be bare minimum requirements for gnus info.
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: Archiving Inbox
2000-08-04 15:17 ` Kai Großjohann
2000-08-04 17:55 ` Harry Putnam
@ 2000-08-06 23:23 ` Rod Whitby
2000-08-07 20:50 ` Arcady Genkin
1 sibling, 1 reply; 7+ messages in thread
From: Rod Whitby @ 2000-08-06 23:23 UTC (permalink / raw)
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1: Type: text/plain; charset=us-ascii, Size: 5226 bytes --]
Kai.Grossjohann@CS.Uni-Dortmund.DE (Kai Großjohann) writes:
> On Fri, 04 Aug 2000, Harry Putnam wrote:
>
> > ((expiry-target . "nnml:target")
> > (expiry-wait . 21 ))
> >
> > ((expiry-target . "nnml:target)
> > (total-expire . t )
> > (expiry-wait . 14 ))
>
> I haven't tried this, but these settings look good. (That is, that's
> what I would have set if I wanted to try the feature.) Is there a bug
> in Gnus?
The functionality of setting nnmail-expiry-target to a string (i.e. a
group to which the expired articles should be moved, instead of being
deleted) just plain does not work. Therefore, there must be no-one
but me using it :-)
Anyway, here's some patches (against a pretty recent snapshot, and I
don't think anything around them has changed since) that do the
following:
1/ [gnus-sum.el, gnus-summary-expire-articles]
Fix the handling of expiry-target group parameters.
2/ [nnml.el, nnml-request-expire-articles]
Fix the calls to nnml-request-article (the filename was being
passed instead of the article number) and
nnmail-expiry-target-group (nnml-current-directory is changed by
nnml-request-accept-article, causing it to be incorrect for the
next article to be expired).
3/ [nnmail.el, nnmail-expiry-target-group]
Fix the call to gnus-request-accept-article so that body encoding
is *not* done. Encoding is not done on incoming mail, so why
should it be done on expired mail?
This is my first patch submission to the ding mailing list, so please
let me know if I should have submitted these in another format (in
particular, how do you get the nice ChangeLog entries?), and also how
I should proceed in getting these checked into CVS.
For those interested, the reason why I found these problems is because
I have just set up my nnml:INBOX to expire to a nnml:DELETED folder
immediately, and then the nnml:DELETED folder really deletes the
messages after a long time. Sort of like the Trash folder in
Netscape, only better :-) Now I can set display to 'all in my
nnml:INBOX group parameters and use the tick marks properly, while
still seeing my other unfiled mail when I enter the folder normally.
diff -c /gnu/XEmacs/site-packages/gnus/lisp/gnus-sum.el~ /gnu/XEmacs/site-packages/gnus/lisp/gnus-sum.el
*** /gnu/XEmacs/site-packages/gnus/lisp/gnus-sum.el~ Tue Jul 25 05:56:17 2000
--- /gnu/XEmacs/site-packages/gnus/lisp/gnus-sum.el Tue Jul 25 05:56:17 2000
***************
*** 7682,7687 ****
--- 7682,7690 ----
(expiry-wait (if now 'immediate
(gnus-group-find-parameter
gnus-newsgroup-name 'expiry-wait)))
+ (nnmail-expiry-target
+ (or (gnus-group-find-parameter gnus-newsgroup-name 'expiry-target)
+ nnmail-expiry-target))
es)
(when expirable
;; There are expirable articles in this group, so we run them
diff -c /gnu/XEmacs/site-packages/gnus/lisp/nnml.el~ /gnu/XEmacs/site-packages/gnus/lisp/nnml.el
*** /gnu/XEmacs/site-packages/gnus/lisp/nnml.el~ Tue Jul 25 05:07:35 2000
--- /gnu/XEmacs/site-packages/gnus/lisp/nnml.el Tue Jul 25 05:07:35 2000
***************
*** 289,300 ****
;; Allow a special target group.
(unless (eq nnmail-expiry-target 'delete)
(with-temp-buffer
! (nnml-request-article article group server
(current-buffer))
! (nnmail-expiry-target-group
! nnmail-expiry-target group)))
(nnheader-message 5 "Deleting article %s in %s"
! article group)
(condition-case ()
(funcall nnmail-delete-file-function article)
(file-error
--- 289,301 ----
;; Allow a special target group.
(unless (eq nnmail-expiry-target 'delete)
(with-temp-buffer
! (nnml-request-article number group server
(current-buffer))
! (let ((nnml-current-directory nil))
! (nnmail-expiry-target-group
! nnmail-expiry-target group))))
(nnheader-message 5 "Deleting article %s in %s"
! number group)
(condition-case ()
(funcall nnmail-delete-file-function article)
(file-error
diff -c /gnu/XEmacs/site-packages/gnus/lisp/nnmail.el~ /gnu/XEmacs/site-packages/gnus/lisp/nnmail.el
*** /gnu/XEmacs/site-packages/gnus/lisp/nnmail.el~ Tue Jul 25 05:08:51 2000
--- /gnu/XEmacs/site-packages/gnus/lisp/nnmail.el Tue Jul 25 05:08:51 2000
***************
*** 1610,1616 ****
(when (nnheader-functionp target)
(setq target (funcall target group)))
(unless (eq target 'delete)
! (gnus-request-accept-article target)))
(defun nnmail-check-syntax ()
"Check (and modify) the syntax of the message in the current buffer."
--- 1610,1616 ----
(when (nnheader-functionp target)
(setq target (funcall target group)))
(unless (eq target 'delete)
! (gnus-request-accept-article target nil nil t)))
(defun nnmail-check-syntax ()
"Check (and modify) the syntax of the message in the current buffer."
--
-- Rod Whitby, Snr Staff Engr, Electronic Design Automation --
-- Motorola Australia Software Centre - Adelaide, Australia --
-- Phone: +61 8 8203 3526, Fax: +61 8 8203 3501, <GMT+9:30> --
^ permalink raw reply [flat|nested] 7+ messages in thread