Gnus development mailing list
 help / color / mirror / Atom feed
From: kai.grossjohann@uni-duisburg.de (Kai Großjohann)
Subject: Re: Threading wrong if showing undownloaded articles
Date: Sun, 09 Mar 2003 12:19:02 +0100	[thread overview]
Message-ID: <841y1gdbyx.fsf@lucy.is.informatik.uni-duisburg.de> (raw)
In-Reply-To: <u4r6dhxh8.fsf@xpediantsolutions.com>

Kevin Greiner <kgreiner@xpediantsolutions.com> writes:

> It sure looks it.  Let's try making a small change to
> gnus-agent-fetch-selected-article :).
>
> Replace the entire call to gnus-summary-update-article-line with
>   (gnus-summary-update-line gnus-current-article)

Oh, boy, I made a Freudian error and made a change in gnus-sum.el
instead.  Then I looked again and saw that you said to make the
change in gnus-agent-fetch-selected-article...

Both changes work.

Are you going to check in the fix to
gnus-agent-fetch-selected-article?

Here is a diff showing what I tried.  The gnus-sum change has been
commented out; the gnus-agent change is active.

cvs server: Diffing lisp
Index: lisp/gnus-agent.el
===================================================================
RCS file: /usr/local/cvsroot/gnus/lisp/gnus-agent.el,v
retrieving revision 6.156
diff -u -r6.156 gnus-agent.el
--- lisp/gnus-agent.el	7 Mar 2003 04:06:25 -0000	6.156
+++ lisp/gnus-agent.el	9 Mar 2003 11:37:29 -0000
@@ -1013,9 +1013,7 @@
 	     (list gnus-current-article))
 	(setq gnus-newsgroup-undownloaded
 	      (delq gnus-current-article gnus-newsgroup-undownloaded))
-	(gnus-summary-update-article-line
-	 gnus-current-article
-	 (gnus-summary-article-header gnus-current-article))))))
+	(gnus-summary-update-line gnus-current-article)))))
 
 ;;;
 ;;; Internal functions
Index: lisp/gnus-sum.el
===================================================================
RCS file: /usr/local/cvsroot/gnus/lisp/gnus-sum.el,v
retrieving revision 6.317
diff -u -r6.317 gnus-sum.el
--- lisp/gnus-sum.el	3 Mar 2003 05:39:24 -0000	6.317
+++ lisp/gnus-sum.el	9 Mar 2003 11:37:51 -0000
@@ -8506,6 +8506,7 @@
 	 header)
 	(gnus-summary-update-article-line
 	 (cdr gnus-article-current) header)
+					; (gnus-summary-update-line gnus-current-article)
 	(when (gnus-summary-goto-subject (cdr gnus-article-current) nil t)
 	  (gnus-summary-update-secondary-mark (cdr gnus-article-current))))))
    ((not arg)

-- 
A preposition is not a good thing to end a sentence with.



  reply	other threads:[~2003-03-09 11:19 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2003-02-27 14:51 Kai Großjohann
2003-02-28  5:46 ` Kevin Greiner
2003-02-28 13:07   ` Kai Großjohann
2003-02-28 13:52     ` Kevin Greiner
2003-03-08 17:12       ` Kai Großjohann
2003-03-08 17:31         ` Kai Großjohann
2003-03-09  6:20         ` Kevin Greiner
2003-03-09 11:19           ` Kai Großjohann [this message]
2003-03-09 14:33             ` Kevin Greiner
2003-03-09 16:39               ` Kai Großjohann

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=841y1gdbyx.fsf@lucy.is.informatik.uni-duisburg.de \
    --to=kai.grossjohann@uni-duisburg.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).