Re: Threading wrong if showing undownloaded articles

[Kevin Greiner <kgreiner@xpediantsolutions.com>]

kai.grossjohann@uni-duisburg.de (Kai Großjohann) writes:

> Kevin Greiner <kgreiner@xpediantsolutions.com> writes:
>
>> Right, the function that I provided should be able to refresh the
>> undownloaded articles.  I suspect that the data structures used by the
>> summary are being corrupted.  I'd like you to find out if that is
>> true.
>
> I have now tested your function test1 on an article and it doesn't
> appear to do anything (except to advance point to the next line).
>
> I'm not 100% sure if the originally reported behavior was the same as
> what I'm seeing now.  What I'm seeing now is that all articles are
> shown correctly initially (the threading is correct).  But when I
> select a non-downloaded article, the summary line changes.  In
> particular, the %B part changes.  It appears that the new %B macro
> always expands to gnus-sum-thread-tree-single-leaf, preceded by one
> or two levels of indentation.  (It's always the same number of
> levels, but I don't know the number offhand.)
>
> Hm.  The thing that's inserted there is
> gnus-tmp-thread-tree-header-string, according to
> gnus-summary-line-format-alist.  So a hypothesis is that this
> variable is b0rked.
>
> Which function is called to show the summary line when I select an
> article?
>
> Ah.  gnus-tmp-thread-tree-header-string is only set in one spot, in
> gnus-summary-prepare-threads.  Hmm...  Oh!  Selecting an article
> appears to call gnus-summary-update-article-line which calls
> gnus-summary-insert-line which does not know about the correct value.
>
> Is this analysis correct?

It sure looks it.  Let's try making a small change to
gnus-agent-fetch-selected-article :).

Replace the entire call to gnus-summary-update-article-line with
  (gnus-summary-update-line gnus-current-article)

Kevin