`gnus-group-read-group' doesn't use `select-article'?

`gnus-group-read-group' doesn't use `select-article'?

[Mike McEwan]

  Well, I tinkered with the above `new' parameter to
`gnus-group-read-group' and friends, but it just wasn't working. At
least, not the way I expect it to. 

  After the usual session with edebug it seemed that `select-article'
wasn't being passed to from `gnus-summary-read-group' to
`gnus-summary-read-group-1'. The following patch does it for me (Lars, 
I'm sure you can let me know if I'm missing something here).

  Having got `select-article' to be passed to
`gnus-summary-read-group-1', I then noticed that where `old' articles
were being selected due to `gnus-fetch-old-headers' not being `nil',
they were all being marked `old' regardless. Setting
`gnus-newsgroup-unselected' in the following, again, does it for me.

-- 
Mike.

--- ChangeLog.orig	Tue Aug  4 04:26:20 1998
+++ ChangeLog	Tue Aug  4 20:27:02 1998
@@ -1,3 +1,12 @@
+1998-08-04  Mike McEwan  <mike@lotusland.demon.co.uk>
+
+	* gnus-sum.el (gnus-select-newsgroup): Set
+	`gnus-newsgroup-unselected' when selecting specific articles via
+	SELECT-ARTICLE - there may be more headers to fetch if
+	`gnus-fetch-old-headers' is non-nil. 
+	(gnus-summary-read-group): pass SELECT-ARTICLE to
+	`gnus-summary-read-group-1' and reset to nil when going to next group.
+
 Tue Aug  4 05:25:01 1998  Lars Magne Ingebrigtsen  <larsi@menja.ifi.uio.no>
 
 	* gnus.el: Gnus v5.6.28 is released.
--- gnus-sum.el.orig	Mon Jul 27 02:25:51 1998
+++ gnus-sum.el	Tue Aug  4 20:16:01 1998
@@ -2519,9 +2519,10 @@
 			    (let ((gnus-auto-select-next nil))
 			      (or (gnus-summary-read-group-1
 				   group show-all no-article
-				   kill-buffer no-display)
-				  (setq show-all nil)
-				  select-article))))
+				   kill-buffer no-display
+				   select-article)
+				  (setq show-all nil
+				   select-article nil)))))
 		(eq gnus-auto-select-next 'quietly))
       (set-buffer gnus-group-buffer)
       ;; The entry function called above goes to the next
@@ -3872,7 +3873,12 @@
     (unless (gnus-ephemeral-group-p gnus-newsgroup-name)
       (gnus-group-update-group group))
 
-    (setq articles (or select-articles (gnus-articles-to-read group read-all)))
+    (if (setq articles select-articles)
+	(setq gnus-newsgroup-unselected
+	      (gnus-sorted-intersection
+	       gnus-newsgroup-unreads
+	       (gnus-sorted-complement gnus-newsgroup-unreads articles)))
+      (setq articles (gnus-articles-to-read group read-all)))
 
     (cond
      ((null articles)

Re: `gnus-group-read-group' doesn't use `select-article'?

[Mike McEwan]

  Talk about pernickety :-)

--- ChangeLog.orig	Tue Aug  4 20:27:02 1998
+++ ChangeLog	Tue Aug  4 21:11:29 1998
@@ -6,6 +6,8 @@
 	`gnus-fetch-old-headers' is non-nil. 
 	(gnus-summary-read-group): pass SELECT-ARTICLE to
 	`gnus-summary-read-group-1' and reset to nil when going to next group.
+	(gnus-summary-read-group): Change `select-article' to
+	`select-articles' for consistency.
 
 Tue Aug  4 05:25:01 1998  Lars Magne Ingebrigtsen  <larsi@menja.ifi.uio.no>
--- gnus-sum.el.orig	Tue Aug  4 21:08:20 1998
+++ gnus-sum.el	Tue Aug  4 21:29:31 1998
@@ -2508,7 +2508,7 @@
 
 (defun gnus-summary-read-group (group &optional show-all no-article
 				      kill-buffer no-display backward
-				      select-article)
+				      select-articles)
   "Start reading news in newsgroup GROUP.
 If SHOW-ALL is non-nil, already read articles are also listed.
 If NO-ARTICLE is non-nil, no article is selected initially.
@@ -2520,9 +2520,9 @@
 			      (or (gnus-summary-read-group-1
 				   group show-all no-article
 				   kill-buffer no-display
-				   select-article)
+				   select-articles)
 				  (setq show-all nil
-				   select-article nil)))))
+				   select-articles nil)))))
 		(eq gnus-auto-select-next 'quietly))
       (set-buffer gnus-group-buffer)
       ;; The entry function called above goes to the next


-- 
Mike.

Re: `gnus-group-read-group' doesn't use `select-article'?

[Kai Grossjohann]

This patch also makes nnir.el work as expected.  Thanks, Mike.
kai
-- 
OOP: object oriented programming;  OOPS: object oriented mistakes