* Problem with gnus-refer-article-method
@ 2000-10-24 21:55 Stefan Wiens
2000-10-24 22:45 ` ShengHuo ZHU
0 siblings, 1 reply; 3+ messages in thread
From: Stefan Wiens @ 2000-10-24 21:55 UTC (permalink / raw)
According to the documentation, the value of gnus-refer-article-method
may be a single select method.
If I make (setq gnus-refer-article-method '(nntp "neon")) and try to
read an old article not displayed in the summary buffer (e.g. by
typing "^"), I get the error "Wrong type argument: listp, nntp".
This does not happen if gnus-refer-article-method is a symbol or a
list of select methods (possibly containing a single method).
I tried to track this down, and found that the
gnus-request-article-this-buffer function doesn't handle this case
properly.
This is my first attempt to fix this:
--- gnus-art.el.orig Sat Jul 01 13:10:42 2000
+++ gnus-art.el Sun Oct 22 22:16:24 2000
@@ -3841,13 +3841,14 @@
(let ((gnus-override-method gnus-override-method)
(methods (and (stringp article)
gnus-refer-article-method))
result
(buffer-read-only nil))
(setq methods
- (if (listp methods)
+ (if (and (listp methods)
+ (not (stringp (cadr methods))))
methods
(list methods)))
(when (and (null gnus-override-method)
methods)
(setq gnus-override-method (pop methods)))
(while (not result)
A single nntp symbol gets "pop"ed into gnus-override-method. My fix
was inspired by the gnus-refer-article-methods function, which
performs a very similar work, but seems to do it correctly.
Stefan
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: Problem with gnus-refer-article-method
2000-10-24 21:55 Problem with gnus-refer-article-method Stefan Wiens
@ 2000-10-24 22:45 ` ShengHuo ZHU
2000-10-25 19:29 ` Stefan Wiens
0 siblings, 1 reply; 3+ messages in thread
From: ShengHuo ZHU @ 2000-10-24 22:45 UTC (permalink / raw)
Stefan Wiens <s.wi@gmx.net> writes:
> According to the documentation, the value of gnus-refer-article-method
> may be a single select method.
>
> If I make (setq gnus-refer-article-method '(nntp "neon")) and try to
> read an old article not displayed in the summary buffer (e.g. by
> typing "^"), I get the error "Wrong type argument: listp, nntp".
>
> This does not happen if gnus-refer-article-method is a symbol or a
> list of select methods (possibly containing a single method).
>
> I tried to track this down, and found that the
> gnus-request-article-this-buffer function doesn't handle this case
> properly.
>
> This is my first attempt to fix this:
>
> --- gnus-art.el.orig Sat Jul 01 13:10:42 2000
> +++ gnus-art.el Sun Oct 22 22:16:24 2000
> @@ -3841,13 +3841,14 @@
> (let ((gnus-override-method gnus-override-method)
> (methods (and (stringp article)
> gnus-refer-article-method))
> result
> (buffer-read-only nil))
> (setq methods
> - (if (listp methods)
> + (if (and (listp methods)
> + (not (stringp (cadr methods))))
> methods
> (list methods)))
> (when (and (null gnus-override-method)
> methods)
> (setq gnus-override-method (pop methods)))
> (while (not result)
>
>
> A single nntp symbol gets "pop"ed into gnus-override-method. My fix
> was inspired by the gnus-refer-article-methods function, which
> performs a very similar work, but seems to do it correctly.
This fix doesn't work for '(current "archive"). Neither does the
gnus-refer-article-methods function. I've installed another patch in
the CVS repository.
ShengHuo
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: Problem with gnus-refer-article-method
2000-10-24 22:45 ` ShengHuo ZHU
@ 2000-10-25 19:29 ` Stefan Wiens
0 siblings, 0 replies; 3+ messages in thread
From: Stefan Wiens @ 2000-10-25 19:29 UTC (permalink / raw)
ShengHuo ZHU <zsh@cs.rochester.edu> writes:
> This fix doesn't work for '(current "archive"). Neither does the
> gnus-refer-article-methods function. I've installed another patch in
> the CVS repository.
Your fix really is more sophisticated :-)
Thanks for your quick reaction.
Stefan
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2000-10-25 19:29 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2000-10-24 21:55 Problem with gnus-refer-article-method Stefan Wiens
2000-10-24 22:45 ` ShengHuo ZHU
2000-10-25 19:29 ` Stefan Wiens
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).