Problem with gnus-refer-article-method

Problem with gnus-refer-article-method

[Stefan Wiens]

According to the documentation, the value of gnus-refer-article-method
may be a single select method.

If I make (setq gnus-refer-article-method '(nntp "neon")) and try to
read an old article not displayed in the summary buffer (e.g. by
typing "^"), I get the error "Wrong type argument: listp, nntp".

This does not happen if gnus-refer-article-method is a symbol or a
list of select methods (possibly containing a single method).

I tried to track this down, and found that the
gnus-request-article-this-buffer function doesn't handle this case
properly.

This is my first attempt to fix this:

--- gnus-art.el.orig	Sat Jul 01 13:10:42 2000
+++ gnus-art.el	Sun Oct 22 22:16:24 2000
@@ -3841,13 +3841,14 @@
 	    (let ((gnus-override-method gnus-override-method)
 		  (methods (and (stringp article) 
 				gnus-refer-article-method))
 		  result
 		  (buffer-read-only nil))
 	      (setq methods
-		    (if (listp methods)
+		    (if (and (listp methods)
+			     (not (stringp (cadr methods))))
 			methods
 		      (list methods)))
 	      (when (and (null gnus-override-method)
 			 methods)
 		(setq gnus-override-method (pop methods)))
 	      (while (not result)


A single nntp symbol gets "pop"ed into gnus-override-method. My fix
was inspired by the gnus-refer-article-methods function, which
performs a very similar work, but seems to do it correctly.

Stefan

Re: Problem with gnus-refer-article-method

[ShengHuo ZHU]

Stefan Wiens <s.wi@gmx.net> writes:

> According to the documentation, the value of gnus-refer-article-method
> may be a single select method.
> 
> If I make (setq gnus-refer-article-method '(nntp "neon")) and try to
> read an old article not displayed in the summary buffer (e.g. by
> typing "^"), I get the error "Wrong type argument: listp, nntp".
> 
> This does not happen if gnus-refer-article-method is a symbol or a
> list of select methods (possibly containing a single method).
> 
> I tried to track this down, and found that the
> gnus-request-article-this-buffer function doesn't handle this case
> properly.
> 
> This is my first attempt to fix this:
> 
> --- gnus-art.el.orig	Sat Jul 01 13:10:42 2000
> +++ gnus-art.el	Sun Oct 22 22:16:24 2000
> @@ -3841,13 +3841,14 @@
>  	    (let ((gnus-override-method gnus-override-method)
>  		  (methods (and (stringp article) 
>  				gnus-refer-article-method))
>  		  result
>  		  (buffer-read-only nil))
>  	      (setq methods
> -		    (if (listp methods)
> +		    (if (and (listp methods)
> +			     (not (stringp (cadr methods))))
>  			methods
>  		      (list methods)))
>  	      (when (and (null gnus-override-method)
>  			 methods)
>  		(setq gnus-override-method (pop methods)))
>  	      (while (not result)
> 
> 
> A single nntp symbol gets "pop"ed into gnus-override-method. My fix
> was inspired by the gnus-refer-article-methods function, which
> performs a very similar work, but seems to do it correctly.

This fix doesn't work for '(current "archive").  Neither does the
gnus-refer-article-methods function.  I've installed another patch in
the CVS repository.

ShengHuo

Re: Problem with gnus-refer-article-method

[Stefan Wiens]

ShengHuo ZHU <zsh@cs.rochester.edu> writes:

> This fix doesn't work for '(current "archive").  Neither does the
> gnus-refer-article-methods function.  I've installed another patch in
> the CVS repository.

Your fix really is more sophisticated :-)

Thanks for your quick reaction.

Stefan