[Edbrowse-dev] error legs first step

[Edbrowse-dev] error legs first step

[Karl Dahlke]

I wanted to ask you about this before I did anything.

I think the first step in error legs is to allow for the possibility
of cw->jss = null.
It would become null if we encountered an error,
and decided to free the java context,
but still march on with the rest of edbrowse.
That would among other things reclaim the memory used by that context.

And I wouldn't even create the context if javascript was disabled
or disabled for that site.
This is something Adam asked about earlier.
It would be just one line of code change in buffers.c line 4850.
But I have to make sure things don't blow up if jss is null.
So many functions now start out with AutoCompartment as their first line;
before that I would put in

if(!cw->jss) return;

Or something like that.
Anyways I would suggest this as the first step.

Karl Dahlke

Re: [Edbrowse-dev] error legs first step

[Chris Brannon]

Karl Dahlke <eklhad@comcast.net> writes:

> I think the first step in error legs is to allow for the possibility
> of cw->jss = null.
> It would become null if we encountered an error,

This sounds good to me.

-- Chris

Re: [Edbrowse-dev] error legs first step

[Adam Thompson]

On Sun, Feb 09, 2014 at 01:50:08PM -0800, Chris Brannon wrote:
> Karl Dahlke <eklhad@comcast.net> writes:
> 
> > I think the first step in error legs is to allow for the possibility
> > of cw->jss = null.
> > It would become null if we encountered an error,
> 
> This sounds good to me.

Same here. To be honest, I've half been thinking of making a macro to do
something like:
#define SWITCH_COMPARTMENT(retval) if ((cw->jss == NULL) || (cw->jss->jcx == NULL)) \
 return (retval); \
JSAutoCompartment ac(cw->jss->jcx, cw->jss->jwin)

Usage would probably look like (for an eb_bool function):
SWITCH_COMPARTMENT(eb_false);

For a void function it would be:
SWITCH_COMPARTMENT(void);

This needs to be a macro for the return,
and of course assumes we never use ac as a var name for something else (could be made a parameter if we need).

Cheers,
Adam.