[Edbrowse-dev] JS interpreter crashes on Google books

[Edbrowse-dev] JS interpreter crashes on Google books

[Sebastian Humenda]

[-- Attachment #1: Type: text/plain, Size: 680 bytes --]

Hi there,

presumably that has been reported before / is known already, but I have a
reproducible crash at the Google Docs site:

    https://docs.google.com/document/d/1jTnjQ6WRFyUE7iKgkMiJMxDmJ-UDzgtpT40i-xm-JoQ/edit?pref=2&pli=1

It seems that Edbrowse is asking for something, it prints [y|n], but no matter
what I type, it repeats the same message over and over again. C-c will make the
js interpreter crash.

Cheers
Sebastian
-- 
Web: http://www.crustulus.de (English|Deutsch)  | Blog: http://www.crustulus.de/blog
FreeDict: Free multilingual dictionaries - http://www.freedict.org
Freies Latein-Deutsch-Wörterbuch: http://www.crustulus.de/freedict.de.html

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 819 bytes --]

[Edbrowse-dev] JS interpreter crashes on Google books

[Karl Dahlke]

Ok I've reduced it to an html file with about 50 lines,
pretty much all javascript, and a local js file that is a megabyte.
I don't have the courage or energy to go any farther right now.
gb is for google books

www.eklhad.net/gb.zip

Karl Dahlke

[Edbrowse-dev] JS interpreter crashes on Google books

[Karl Dahlke]

Well gdb cuts to the heart of it, as it often does.
The problem is in the new xhr system when cw (current window) is null.
And why didn't we see this in our jsrt test?
Because that test runs innerHTML first, which sets cw.
This page has no innerHTML, cw was never set, then xhr blows up.
So I now set cw at the start of js_main().

Not sure the result is much better though.
js script doesn't run perfectly, which reports an error to google via xhr,
and too many errors like this can cause google to block your site, for a while.
google is so complicated, it's not clear edbrowse
will ever truly be able to handle it.
This page does however have {toggle screen reader mode}.
Not sure what that does.

Karl Dahlke

Re: [Edbrowse-dev] JS interpreter crashes on Google books

[Sebastian Humenda]

[-- Attachment #1: Type: text/plain, Size: 590 bytes --]

Hi,

Karl Dahlke schrieb am 22.01.2016,  7:41 -0500:
>Well gdb cuts to the heart of it, as it often does.
>The problem is in the new xhr system when cw (current window) is null.
[...]
Thanks for investigating it.

>Not sure the result is much better though.
Do you want me to test it or is a second opinion not of any help?

Cheers
Sebastian
-- 
Web: http://www.crustulus.de (English|Deutsch)  | Blog: http://www.crustulus.de/blog
FreeDict: Free multilingual dictionaries - http://www.freedict.org
Freies Latein-Deutsch-Wörterbuch: http://www.crustulus.de/freedict.de.html

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 819 bytes --]

Re: [Edbrowse-dev] JS interpreter crashes on Google books

[Kevin Carhart]

> The problem is in the new xhr system when cw (current window) is null.

> So I now set cw at the start of js_main().

Ahh.  Thanks for doing this.

Kevin