Re: exit_status persistence.

[Ingo Schwarze <schwarze@usta.de>]

Hi Kristaps,

Kristaps Dzonsons wrote on Wed, Dec 01, 2010 at 05:33:52PM +0100:

> Ingo, I flushed out some peculiar behaviour in the new main.c.
> 
> If a FATAL parse error occurs (e.g., rxdebug.1) when multiple files
> are passed on the command-line, subsequent files are parsed but not
> outputted.  This occurs due to main.c:484.  I don't want to monkey
> with exit_status---can you verify that exit_status may somehow be
> saved or reset between parses so that passing multiple files doesn't
> cause truncated output?

Looking at the code, i'd say you are right, this looks like a blatant
design error and needs to be fixed.
I'll probably split exit_status into two variables:
First, file_status will be initialized to MANDOCERR_OK for each
file, and that's the one mmsg will write to.
Then, at the end of each file, the contents must be moved to
exit_status, in case it's more severe than what is already there.

I'll cook up a patch after completing the bsd.lv -> OpenBSD merges.
Merge, then write code is usually better than the other way round.  :)

Yours,
  Ingo
--
 To unsubscribe send an email to tech+unsubscribe@mdocml.bsd.lv