tech@mandoc.bsd.lv
 help / color / mirror / Atom feed
From: Kristaps Dzonsons <kristaps@bsd.lv>
To: tech@mdocml.bsd.lv
Subject: Re: exit_status persistence (now: roff.c question).
Date: Thu, 02 Dec 2010 11:51:23 +0100	[thread overview]
Message-ID: <4CF77A2B.6020702@bsd.lv> (raw)
In-Reply-To: <20101201212834.GA22990@iris.usta.de>

>> Ingo, I flushed out some peculiar behaviour in the new main.c.
>>
>> If a FATAL parse error occurs (e.g., rxdebug.1) when multiple files
>> are passed on the command-line, subsequent files are parsed but not
>> outputted.  This occurs due to main.c:484.  I don't want to monkey
>> with exit_status---can you verify that exit_status may somehow be
>> saved or reset between parses so that passing multiple files doesn't
>> cause truncated output?
>
> Looking at the code, i'd say you are right, this looks like a blatant
> design error and needs to be fixed.
> I'll probably split exit_status into two variables:
> First, file_status will be initialized to MANDOCERR_OK for each
> file, and that's the one mmsg will write to.
> Then, at the end of each file, the contents must be moved to
> exit_status, in case it's more severe than what is already there.
>
> I'll cook up a patch after completing the bsd.lv ->  OpenBSD merges.
> Merge, then write code is usually better than the other way round.  :)

Another question---I'm about to check in roff.c as fully in sync after 
running some more tests---I notice that `de1' has been removed from the 
switch statement at roff.c:549.  I understand this is because `de1' is 
renamed at roff.c:636.  If this is the case, can you document this 
process a bit more?

There's also an infinite loop somewhere in these new roff.c changes 
that's causing the NetBSD manuals to blow up...

--
 To unsubscribe send an email to tech+unsubscribe@mdocml.bsd.lv

  reply	other threads:[~2010-12-02 10:51 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-12-01 16:33 exit_status persistence Kristaps Dzonsons
2010-12-01 16:41 ` Kristaps Dzonsons
2010-12-01 21:28 ` Ingo Schwarze
2010-12-02 10:51   ` Kristaps Dzonsons [this message]
2010-12-02 13:29     ` exit_status persistence (now: roff.c question) Kristaps Dzonsons
2010-12-02 22:50       ` roff.c question Ingo Schwarze
2010-12-03 21:49         ` Ingo Schwarze
2010-12-05 15:15           ` Kristaps Dzonsons
2010-12-08  1:05             ` Ingo Schwarze
2010-12-10  9:40               ` Kristaps Dzonsons
2010-12-10 20:45                 ` Ingo Schwarze
2010-12-10 20:52                   ` Joerg Sonnenberger
2010-12-10 21:10                     ` Ingo Schwarze
2010-12-10 21:17                       ` Joerg Sonnenberger
2010-12-10 23:12                       ` Ingo Schwarze
2010-12-03 23:31         ` Ingo Schwarze
2010-12-05 15:17           ` Kristaps Dzonsons
2010-12-09 23:45             ` Ingo Schwarze
2010-12-10  9:32               ` Kristaps Dzonsons
2010-12-02 20:54     ` Ingo Schwarze

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4CF77A2B.6020702@bsd.lv \
    --to=kristaps@bsd.lv \
    --cc=tech@mdocml.bsd.lv \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).