Package build failure with musl 1.1.19 + Linux 4.14.48 (UAPI?)

Package build failure with musl 1.1.19 + Linux 4.14.48 (UAPI?)

[A. Wilcox]

[-- Attachment #1.1: Type: text/plain, Size: 1096 bytes --]

Hi there,

Attempting to build net-tools 1.60 on musl 1.1.19 with Linux headers
from kernel 4.14.48 installed on a PowerPC computer, we're seeing the
following build error:


In file included from /usr/include/linux/if_tunnel.h:7:0,
                 from iptunnel.c:34:
/usr/include/linux/ip.h:86:8: error: redefinition of ‘struct iphdr’
 struct iphdr {
        ^~~~~
In file included from iptunnel.c:29:0:
/usr/include/netinet/ip.h:25:8: note: originally defined here
 struct iphdr {
        ^~~~~
make: *** [Makefile:94: iptunnel.o] Error 1


This failure was not present with kernel headers from 4.4.  This may be
a regression in the kernel or it may just be a change that needs to be
made to musl.  I am not very experienced in dealing with UAPI and didn't
see much in the kernel doc tree so I was wondering if someone on this
list could point me towards any resources about how to debug/fix such
issues.

Thank you for your time and attention.

Best to you and yours,
--arw

-- 
A. Wilcox (awilfox)
Project Lead, Adélie Linux
http://adelielinux.org


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

Re: Package build failure with musl 1.1.19 + Linux 4.14.48 (UAPI?)

[Rich Felker]

On Tue, Jun 26, 2018 at 06:19:49PM -0500, A. Wilcox wrote:
> Hi there,
> 
> Attempting to build net-tools 1.60 on musl 1.1.19 with Linux headers
> from kernel 4.14.48 installed on a PowerPC computer, we're seeing the
> following build error:
> 
> 
> In file included from /usr/include/linux/if_tunnel.h:7:0,
>                  from iptunnel.c:34:
> /usr/include/linux/ip.h:86:8: error: redefinition of ‘struct iphdr’
>  struct iphdr {
>         ^~~~~
> In file included from iptunnel.c:29:0:
> /usr/include/netinet/ip.h:25:8: note: originally defined here
>  struct iphdr {
>         ^~~~~
> make: *** [Makefile:94: iptunnel.o] Error 1
> 
> 
> This failure was not present with kernel headers from 4.4.  This may be
> a regression in the kernel or it may just be a change that needs to be
> made to musl.  I am not very experienced in dealing with UAPI and didn't
> see much in the kernel doc tree so I was wondering if someone on this
> list could point me towards any resources about how to debug/fix such
> issues.
> 
> Thank you for your time and attention.

The breakage was introduced in 2016 in Linux commit
1fe8e0f074c77aa41aaa579345a9e675acbebfa9. Incidentally, they *knew*
this was wrong back in 2009; before the UAPI headers were separated
out, commit 0afd4a21ba7d75e93fa79cf05d7a21774e149c0f documents that if
if_tunnel.h includes linux/ip.h it will break userspace, and puts it
under #ifdef __KERNEL__.

Rich

Re: Package build failure with musl 1.1.19 + Linux 4.14.48 (UAPI?)

[Khem Raj]

On Tue, Jun 26, 2018 at 4:19 PM A. Wilcox <awilfox@adelielinux.org> wrote:
>
> Hi there,
>
> Attempting to build net-tools 1.60 on musl 1.1.19 with Linux headers
> from kernel 4.14.48 installed on a PowerPC computer, we're seeing the
> following build error:
>
>
> In file included from /usr/include/linux/if_tunnel.h:7:0,
>                  from iptunnel.c:34:
> /usr/include/linux/ip.h:86:8: error: redefinition of ‘struct iphdr’
>  struct iphdr {
>         ^~~~~
> In file included from iptunnel.c:29:0:
> /usr/include/netinet/ip.h:25:8: note: originally defined here
>  struct iphdr {
>         ^~~~~
> make: *** [Makefile:94: iptunnel.o] Error 1
>
>
> This failure was not present with kernel headers from 4.4.  This may be
> a regression in the kernel or it may just be a change that needs to be
> made to musl.  I am not very experienced in dealing with UAPI and didn't
> see much in the kernel doc tree so I was wondering if someone on this
> list could point me towards any resources about how to debug/fix such
> issues.
>
> Thank you for your time and attention.
>

you might want to apply this patch posted here
https://sourceforge.net/p/net-tools/mailman/message/35413022/

> Best to you and yours,
> --arw
>
> --
> A. Wilcox (awilfox)
> Project Lead, Adélie Linux
> http://adelielinux.org
>