From: Rich Felker <dalias@libc.org>
To: Alejandro Colomar <alx@kernel.org>
Cc: Paul Eggert <eggert@cs.ucla.edu>, Sam James <sam@gentoo.org>,
libc-coord@lists.openwall.com, linux-man@vger.kernel.org,
"A . Wilcox" <AWilcox@wilcox-tech.com>,
Jonathan Wakely <jwakely@redhat.com>,
libc-alpha@sourceware.org, musl@lists.openwall.com,
Szabolcs Nagy <nsz@port70.net>, Jakub Wilk <jwilk@jwilk.net>
Subject: Re: [musl] Re: [libc-coord] [PATCH v4] off64_t: prefer off_t for splice, etc.
Date: Sat, 15 Jul 2023 14:35:11 -0400 [thread overview]
Message-ID: <20230715183511.GJ4163@brightrain.aerifal.cx> (raw)
In-Reply-To: <3d36e6b2-57be-148e-a6fa-d7734279671d@kernel.org>
On Sat, Jul 15, 2023 at 05:08:18PM +0200, Alejandro Colomar wrote:
> Hi Paul, Sam, and Rich,
>
> On 2023-07-09 08:16, Sam James wrote:
> >
> > Paul Eggert <eggert@cs.ucla.edu> writes:
> >
> >> For the few functions that come only in 64-bit off_t flavors,
> >> document their APIs as using off_t instead of off64_t,
> >> and say also that code should #define _FILE_OFFSET_BITS 64.
> >> This documents what user code is (and should be) doing anyway,
> >> if it needs to work on traditional x86 and ARM Linux.
> >
> > LGTM and thank you Paul.
> >
> > I haven't checked for other prototypes/examples which need
> > changing.
>
> Thanks, I'm going to apply the patch. Can you please confirm if I'm
> correct in adding the following tags?
>
> Reported-by: Rich Felker <dalias@libc.org>
> Fixes: 9bebb17e5b57 ("splice.2: Use 'off64_t' instead of 'loff_t'")
> Fixes: 76c5631fb442 ("copy_file_range.2: Document glibc wrapper instead of kernel syscall")
> Fixes: 5cabfa06b407 ("man-pages 1.68")
> Fixes: 3ca974e3988a ("New page for sync_file_range(2), new in kernel 2.6.17.")
> Fixes: 9bebb17e5b57 ("sync_file_range.2: Document the architecture-specific sync_file_range2() system call")
> Fixes: 79bf8cdcf36a ("Document fopencookie(3), a library function that allows custom implementation of a stdio stream.")
> Signed-off-by: Paul Eggert <eggert@cs.ucla.edu>
> Reviewed-by: Sam James <sam@gentoo.org>
> Cc: Jonathan Wakely <jwakely@redhat.com>
> Cc: Szabolcs Nagy <nsz@port70.net>
> Cc: Jakub Wilk <jwilk@jwilk.net>
> Cc: A. Wilcox <AWilcox@wilcox-tech.com>
> Signed-off-by: Alejandro Colomar <alx@kernel.org>
>
>
> BTW, Rich, please note the commits that this fixes: most of them are
> the initial commit that adds a page, which means that the function
> had always been documented with off64_t in the "spec". Only splice(2)
> and copy_file_range(2) have been adjusted afterwards, and in a manner
> to be consistent with the rest of the pages, so I can only conclude
> that we didn't break the spec, but rather fixed it.
>
> Nevertheless, I'm sorry that it caused any problems to musl, and I'm
> happy that you reported them and so we can now improve the pages.
While I like off_t, I am still unhappy that this seems to have been a
unilateral action from documentation side without even hearing input
from any major implementors other than myself. Is "you can't use these
interfaces without -D_FILE_OFFSET_BITS=64" an acceptable outcome to
the glibc folks?
Rich
next prev parent reply other threads:[~2023-07-15 18:35 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-28 17:53 [musl] regression in man pages for interfaces using loff_t Rich Felker
2023-06-28 18:21 ` [musl] " Paul Eggert
2023-06-28 19:15 ` Rich Felker
2023-06-30 7:11 ` Paul Eggert
2023-06-30 8:02 ` [musl] Re: [libc-coord] " Jonathan Wakely
2023-06-30 8:14 ` Jonathan Wakely
2023-06-30 8:30 ` Sam James
2023-06-30 19:44 ` Paul Eggert
2023-07-02 1:18 ` A. Wilcox
2023-07-02 19:21 ` Paul Eggert
2023-07-03 18:16 ` Jakub Wilk
2023-07-03 21:35 ` Paul Eggert
2023-07-08 17:03 ` Alejandro Colomar
2023-07-09 6:07 ` [musl] [PATCH v4] off64_t: prefer off_t for splice, etc Paul Eggert
2023-07-09 6:16 ` [musl] Re: [libc-coord] " Sam James
2023-07-15 15:08 ` Alejandro Colomar
2023-07-15 18:35 ` Rich Felker [this message]
2023-07-15 20:01 ` Paul Eggert
2023-07-16 0:35 ` Alejandro Colomar
2023-07-16 0:39 ` Alejandro Colomar
2023-06-30 23:37 ` [musl] Re: regression in man pages for interfaces using loff_t Rich Felker
2023-07-01 7:24 ` [musl] Re: [libc-coord] " Paul Eggert
2023-07-01 13:36 ` Szabolcs Nagy
2023-07-01 23:02 ` Paul Eggert
2023-07-01 14:32 ` Rich Felker
2023-07-01 18:45 ` Alejandro Colomar
2023-07-01 23:06 ` Paul Eggert
2023-06-28 19:19 ` Szabolcs Nagy
2023-06-28 19:28 ` Rich Felker
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230715183511.GJ4163@brightrain.aerifal.cx \
--to=dalias@libc.org \
--cc=AWilcox@wilcox-tech.com \
--cc=alx@kernel.org \
--cc=eggert@cs.ucla.edu \
--cc=jwakely@redhat.com \
--cc=jwilk@jwilk.net \
--cc=libc-alpha@sourceware.org \
--cc=libc-coord@lists.openwall.com \
--cc=linux-man@vger.kernel.org \
--cc=musl@lists.openwall.com \
--cc=nsz@port70.net \
--cc=sam@gentoo.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.vuxu.org/mirror/musl/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).