[musl] LoongArch: delete bits/ptrace.h

[musl] LoongArch: delete bits/ptrace.h

[Hongliang Wang]

[-- Attachment #1: Type: text/plain, Size: 614 bytes --]

Hi,

Delete loongarch64/bits/ptrace.h, the PTRACE related macro definitions
are not used in loongarch.

---
  arch/loongarch64/bits/ptrace.h | 4 ----
  1 file changed, 4 deletions(-)
  delete mode 100644 arch/loongarch64/bits/ptrace.h

diff --git a/arch/loongarch64/bits/ptrace.h b/arch/loongarch64/bits/ptrace.h
deleted file mode 100644
index dce2fa51..00000000
--- a/arch/loongarch64/bits/ptrace.h
+++ /dev/null
@@ -1,4 +0,0 @@
-#define PTRACE_GET_THREAD_AREA  25
-#define PTRACE_SET_THREAD_AREA  26
-#define PTRACE_GET_WATCH_REGS   0xd0
-#define PTRACE_SET_WATCH_REGS   0xd1
-- 
2.37.1

Regards,
Hongliang Wang

[-- Attachment #2: 0001-LoongArch-PTRACE-Delete-unused-definition-in-ptrace..patch --]
[-- Type: text/x-patch, Size: 770 bytes --]

From 66564678daed7fcf6a836ecf83f8fc2e173dffc6 Mon Sep 17 00:00:00 2001
From: wanghongliang <wanghongliang@loongson.cn>
Date: Mon, 26 Feb 2024 02:17:17 +0800
Subject: [PATCH] LoongArch:PTRACE:Delete unused definition in ptrace.h.

Signed-off-by: wanghongliang <wanghongliang@loongson.cn>
---
 arch/loongarch64/bits/ptrace.h | 4 ----
 1 file changed, 4 deletions(-)
 delete mode 100644 arch/loongarch64/bits/ptrace.h

diff --git a/arch/loongarch64/bits/ptrace.h b/arch/loongarch64/bits/ptrace.h
deleted file mode 100644
index dce2fa51..00000000
--- a/arch/loongarch64/bits/ptrace.h
+++ /dev/null
@@ -1,4 +0,0 @@
-#define PTRACE_GET_THREAD_AREA  25
-#define PTRACE_SET_THREAD_AREA  26
-#define PTRACE_GET_WATCH_REGS   0xd0
-#define PTRACE_SET_WATCH_REGS   0xd1
-- 
2.37.1

Re: [musl] LoongArch: delete bits/ptrace.h

[Rich Felker]

On Wed, Feb 28, 2024 at 03:27:07PM +0800, Hongliang Wang wrote:
> Hi,
> 
> Delete loongarch64/bits/ptrace.h, the PTRACE related macro definitions
> are not used in loongarch.

I'm applying this based on being unable to find macros like these in
the glibc loongarch64 target, but for future reference, please include
with patches like this an explanation of why they're being removed --
whether they were originally added by mistake, or added intentionally
but then it was decided not to support them, or whatever.

Rich

Re: [musl] LoongArch: delete bits/ptrace.h

[Hongliang Wang]

在 2024/3/1 上午6:29, Rich Felker 写道:
> On Wed, Feb 28, 2024 at 03:27:07PM +0800, Hongliang Wang wrote:
>> Hi,
>>
>> Delete loongarch64/bits/ptrace.h, the PTRACE related macro definitions
>> are not used in loongarch.
> 
> I'm applying this based on being unable to find macros like these in
> the glibc loongarch64 target, but for future reference, please include
> with patches like this an explanation of why they're being removed --
> whether they were originally added by mistake, or added intentionally
> but then it was decided not to support them, or whatever.
> 
> Rich
> 
Sorry, it was my mistake that I didn't explain the reason clearly.
Initialy, these macros in ptrace.h were ported with reference to mips,
they are not used in loongarch, so they were originally added by mistake.

Thank you for pointing out the issue.

Regards,
Hongliang Wang