* [musl] LoongArch: delete bits/ptrace.h
@ 2024-02-28 7:27 Hongliang Wang
2024-02-29 22:29 ` Rich Felker
0 siblings, 1 reply; 3+ messages in thread
From: Hongliang Wang @ 2024-02-28 7:27 UTC (permalink / raw)
To: musl
[-- Attachment #1: Type: text/plain, Size: 614 bytes --]
Hi,
Delete loongarch64/bits/ptrace.h, the PTRACE related macro definitions
are not used in loongarch.
---
arch/loongarch64/bits/ptrace.h | 4 ----
1 file changed, 4 deletions(-)
delete mode 100644 arch/loongarch64/bits/ptrace.h
diff --git a/arch/loongarch64/bits/ptrace.h b/arch/loongarch64/bits/ptrace.h
deleted file mode 100644
index dce2fa51..00000000
--- a/arch/loongarch64/bits/ptrace.h
+++ /dev/null
@@ -1,4 +0,0 @@
-#define PTRACE_GET_THREAD_AREA 25
-#define PTRACE_SET_THREAD_AREA 26
-#define PTRACE_GET_WATCH_REGS 0xd0
-#define PTRACE_SET_WATCH_REGS 0xd1
--
2.37.1
Regards,
Hongliang Wang
[-- Attachment #2: 0001-LoongArch-PTRACE-Delete-unused-definition-in-ptrace..patch --]
[-- Type: text/x-patch, Size: 770 bytes --]
From 66564678daed7fcf6a836ecf83f8fc2e173dffc6 Mon Sep 17 00:00:00 2001
From: wanghongliang <wanghongliang@loongson.cn>
Date: Mon, 26 Feb 2024 02:17:17 +0800
Subject: [PATCH] LoongArch:PTRACE:Delete unused definition in ptrace.h.
Signed-off-by: wanghongliang <wanghongliang@loongson.cn>
---
arch/loongarch64/bits/ptrace.h | 4 ----
1 file changed, 4 deletions(-)
delete mode 100644 arch/loongarch64/bits/ptrace.h
diff --git a/arch/loongarch64/bits/ptrace.h b/arch/loongarch64/bits/ptrace.h
deleted file mode 100644
index dce2fa51..00000000
--- a/arch/loongarch64/bits/ptrace.h
+++ /dev/null
@@ -1,4 +0,0 @@
-#define PTRACE_GET_THREAD_AREA 25
-#define PTRACE_SET_THREAD_AREA 26
-#define PTRACE_GET_WATCH_REGS 0xd0
-#define PTRACE_SET_WATCH_REGS 0xd1
--
2.37.1
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [musl] LoongArch: delete bits/ptrace.h
2024-02-28 7:27 [musl] LoongArch: delete bits/ptrace.h Hongliang Wang
@ 2024-02-29 22:29 ` Rich Felker
2024-03-01 2:00 ` Hongliang Wang
0 siblings, 1 reply; 3+ messages in thread
From: Rich Felker @ 2024-02-29 22:29 UTC (permalink / raw)
To: Hongliang Wang; +Cc: musl
On Wed, Feb 28, 2024 at 03:27:07PM +0800, Hongliang Wang wrote:
> Hi,
>
> Delete loongarch64/bits/ptrace.h, the PTRACE related macro definitions
> are not used in loongarch.
I'm applying this based on being unable to find macros like these in
the glibc loongarch64 target, but for future reference, please include
with patches like this an explanation of why they're being removed --
whether they were originally added by mistake, or added intentionally
but then it was decided not to support them, or whatever.
Rich
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [musl] LoongArch: delete bits/ptrace.h
2024-02-29 22:29 ` Rich Felker
@ 2024-03-01 2:00 ` Hongliang Wang
0 siblings, 0 replies; 3+ messages in thread
From: Hongliang Wang @ 2024-03-01 2:00 UTC (permalink / raw)
To: Rich Felker; +Cc: musl
在 2024/3/1 上午6:29, Rich Felker 写道:
> On Wed, Feb 28, 2024 at 03:27:07PM +0800, Hongliang Wang wrote:
>> Hi,
>>
>> Delete loongarch64/bits/ptrace.h, the PTRACE related macro definitions
>> are not used in loongarch.
>
> I'm applying this based on being unable to find macros like these in
> the glibc loongarch64 target, but for future reference, please include
> with patches like this an explanation of why they're being removed --
> whether they were originally added by mistake, or added intentionally
> but then it was decided not to support them, or whatever.
>
> Rich
>
Sorry, it was my mistake that I didn't explain the reason clearly.
Initialy, these macros in ptrace.h were ported with reference to mips,
they are not used in loongarch, so they were originally added by mistake.
Thank you for pointing out the issue.
Regards,
Hongliang Wang
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2024-03-01 2:00 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2024-02-28 7:27 [musl] LoongArch: delete bits/ptrace.h Hongliang Wang
2024-02-29 22:29 ` Rich Felker
2024-03-01 2:00 ` Hongliang Wang
Code repositories for project(s) associated with this public inbox
https://git.vuxu.org/mirror/musl/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).